Skip to content
This repository has been archived by the owner. It is now read-only.

Suggestion: display badge counter when 0 element is blocked #8989

Closed
Zuzu-Typ opened this issue May 21, 2017 · 7 comments
Closed

Suggestion: display badge counter when 0 element is blocked #8989

Zuzu-Typ opened this issue May 21, 2017 · 7 comments

Comments

@Zuzu-Typ
Copy link

@Zuzu-Typ Zuzu-Typ commented May 21, 2017

  • Did you search for similar issues before submitting this one?
    No

  • Describe the issue you encountered:
    The Transifex key "blockedCountBadge" refers to the text "Display block count badge on shields button", which implies that you could see the blocked count on the button, which is clearly not the case.
    It is shown in the shields panel.

  • Screenshot if needed:
    Shields Panel:
    panelsnip
    As opposed to the button (where there is no blocked count badge to my eyes)
    buttonsnip

@luixxiul
Copy link
Contributor

@luixxiul luixxiul commented May 21, 2017

screenshot 2017-05-21 22 17 25

@luixxiul
Copy link
Contributor

@luixxiul luixxiul commented May 21, 2017

So do you mean the null count should also be displayed like this?

screenshot 2017-05-21 22 18 56

@Zuzu-Typ
Copy link
Author

@Zuzu-Typ Zuzu-Typ commented May 21, 2017

In that case I think it is ok how it is. I just never noticed the counter.

Sorry to waste your time.

@luixxiul luixxiul changed the title Language key "blockedCountBadge" confusion Suggestion: display badge counter when 0 element is blocked May 21, 2017
@luixxiul luixxiul added the suggestion label May 21, 2017
@luixxiul
Copy link
Contributor

@luixxiul luixxiul commented May 21, 2017

np, I just changed this ticket into a suggestion, which is +1 from me.

Now we have the option available, zero should be displayed by default as long as show badge counter is enabled.

@kumarrishav
Copy link
Contributor

@kumarrishav kumarrishav commented May 21, 2017

@srirambv
Copy link
Collaborator

@srirambv srirambv commented May 22, 2017

The count was shown as 0 initially when nothing was blocked but then reverted here 29acdac for #7873

@bsclifton
Copy link
Member

@bsclifton bsclifton commented Sep 9, 2018

Duplicate of #11106

@bsclifton bsclifton marked this as a duplicate of #11106 Sep 9, 2018
@bsclifton bsclifton closed this Sep 9, 2018
@bsclifton bsclifton added the duplicate label Sep 9, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Sep 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.