This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upconverting BrowserButton tracking issue #9071
Closed
Assignees
Comments
This was referenced May 26, 2017
cezaraugusto
added a commit
that referenced
this issue
May 30, 2017
Closes #9072 Addresses #9071 Also: - Add lines in the same way as LESS files - Add comments for refenrence (We could remove them after refactoring work) - Fix regressions on browserButton_default - Add globalStyles.button.color to replace it with globalStyles.button.default.color - Fix a typo Auditors: Test Plan 1: (0. Take a screenshot of the buttons section on about:styles before testing the PR for later use) 1. Open about:styles 2. Click "buttons" 3. Take another screenshot of the section 4. Compare the two screenshots and make sure they look same Test Plan 2: 1. Open about:styles 2. Toggle developer tools 3. Make sure button's padding is set to '5px 16px' Test Plan 3: 1. Open downloadme.org 2. Click "Advanced" button 3. Make sure the button is not pushed down 4. Click "Hide advanced" button 5. Make sure the button does not move
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the issue you encountered: converting BrowserButton tracking issue. This is a follow up to #8568