This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIgnore package-lock.json temporarily #10720
Closed
Conversation
Let's revert it after travis-ci/travis-ci#7936 is fixed. See: #9691 (comment) Addresses #8283 Test Plan: 1. rm -rf node_modules 2. npm install 3. git status 3. make sure package-lock.json is no longer listed
|
We should instead be committing a package-lock.json and not ignoring it. |
|
I see! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
luixxiul commentedAug 30, 2017
•
edited
Let's revert it after travis-ci/travis-ci#7936 is fixed. See: #9691 (comment)
Addresses #8283
Test Plan:
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests