Skip to content
This repository has been archived by the owner. It is now read-only.

Ignore package-lock.json temporarily #10720

Closed
wants to merge 1 commit into from
Closed

Conversation

@luixxiul
Copy link
Contributor

luixxiul commented Aug 30, 2017

Let's revert it after travis-ci/travis-ci#7936 is fixed. See: #9691 (comment)

Addresses #8283

Test Plan:

  1. rm -rf node_modules
  2. npm install
  3. git status
  4. make sure package-lock.json is no longer listed

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Aug 30, 2017
@luixxiul luixxiul self-assigned this Aug 30, 2017
Suguru Hirahara
Let's revert it after travis-ci/travis-ci#7936 is fixed. See: #9691 (comment)

Addresses #8283

Test Plan:
1. rm -rf node_modules
2. npm install
3. git status
3. make sure package-lock.json is no longer listed
@luixxiul luixxiul requested a review from bsclifton Sep 7, 2017
Copy link
Member

bbondy left a comment

We should instead be committing a package-lock.json and not ignoring it.

@luixxiul luixxiul closed this Sep 8, 2017
@luixxiul luixxiul deleted the luixxiul:gitignore-package-lock branch Sep 8, 2017
@luixxiul
Copy link
Contributor Author

luixxiul commented Sep 8, 2017

I see!

@luixxiul luixxiul removed this from the 0.21.x (Nightly Channel) milestone Sep 8, 2017
@luixxiul luixxiul removed the request for review from bsclifton Sep 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.