This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upremove unittest from pre-push hook #11084
Merged
+3
−2
Conversation
codecov-io
commented
Sep 21, 2017
•
Codecov Report
@@ Coverage Diff @@
## master #11084 +/- ##
==========================================
+ Coverage 52.6% 53.5% +0.89%
==========================================
Files 268 251 -17
Lines 25237 21885 -3352
Branches 4024 3446 -578
==========================================
- Hits 13277 11709 -1568
+ Misses 11960 10176 -1784
|
| @@ -3,7 +3,7 @@ | |||
| * You can obtain one at http://mozilla.org/MPL/2.0/. */ | |||
|
|
|||
| module.exports = [ | |||
| 'pre-comit', | |||
| 'pre-commit', | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@diracdeltas what do you think about updating the push hook to not run if you have a specific environment variable defined, like NO_PUSH_HOOK_TESTS. If that's defined, we can just noop |
|
@bsclifton that's a reasonable option |
|
@bsclifton done! |
bbondy
added a commit
that referenced
this pull request
Oct 26, 2017
remove unittest from pre-push hook
bbondy
added a commit
that referenced
this pull request
Oct 26, 2017
remove unittest from pre-push hook
bbondy
added a commit
that referenced
this pull request
Oct 26, 2017
remove unittest from pre-push hook
|
++ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
diracdeltas commentedSep 21, 2017
fix #11081