Skip to content
This repository has been archived by the owner. It is now read-only.

remove unittest from pre-push hook #11084

Merged
merged 1 commit into from Oct 26, 2017
Merged

remove unittest from pre-push hook #11084

merged 1 commit into from Oct 26, 2017

Conversation

@diracdeltas
Copy link
Member

diracdeltas commented Sep 21, 2017

fix #11081

@diracdeltas diracdeltas requested a review from bsclifton Sep 21, 2017
@codecov-io
Copy link

codecov-io commented Sep 21, 2017

Codecov Report

Merging #11084 into master will increase coverage by 0.89%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11084      +/-   ##
==========================================
+ Coverage    52.6%    53.5%   +0.89%     
==========================================
  Files         268      251      -17     
  Lines       25237    21885    -3352     
  Branches     4024     3446     -578     
==========================================
- Hits        13277    11709    -1568     
+ Misses      11960    10176    -1784
Flag Coverage Δ
#unittest 53.5% <ø> (+0.89%) ⬆️
Impacted Files Coverage Δ
app/common/lib/bookmarkUtil.js 58.55% <0%> (-40.77%) ⬇️
app/renderer/components/common/browserButton.js 69.04% <0%> (-26.31%) ⬇️
app/renderer/components/tabs/content/tabIcon.js 45.83% <0%> (-13.26%) ⬇️
app/renderer/components/common/dropdown.js 90.62% <0%> (-9.38%) ⬇️
app/common/state/bookmarkFoldersState.js 67.15% <0%> (-7.66%) ⬇️
app/common/state/bookmarksState.js 80.79% <0%> (-7.04%) ⬇️
app/renderer/reducers/frameReducer.js 50.73% <0%> (-6.28%) ⬇️
...p/renderer/components/tabs/content/closeTabIcon.js 39.06% <0%> (-6.04%) ⬇️
app/common/state/tabUIState.js 25.2% <0%> (-5.49%) ⬇️
app/renderer/reducers/urlBarReducer.js 72.11% <0%> (-4.52%) ⬇️
... and 83 more
@@ -3,7 +3,7 @@
* You can obtain one at http://mozilla.org/MPL/2.0/. */

module.exports = [
'pre-comit',
'pre-commit',

This comment has been minimized.

Copy link
@luixxiul

luixxiul Sep 30, 2017

Contributor

I've been not sure if this was a typo: #9690 (comment)

This comment has been minimized.

Copy link
@diracdeltas

diracdeltas Oct 10, 2017

Author Member

cc @NejcZdovc on whether this is a typo

This comment has been minimized.

Copy link
@bbondy

bbondy Oct 26, 2017

Member

These are sub-dirs of node_modules mostly so yes it's a typo. Thx.

Copy link
Member

bsclifton left a comment

@diracdeltas what do you think about updating the push hook to not run if you have a specific environment variable defined, like NO_PUSH_HOOK_TESTS. If that's defined, we can just noop

@diracdeltas
Copy link
Member Author

diracdeltas commented Oct 18, 2017

@bsclifton that's a reasonable option

@diracdeltas diracdeltas force-pushed the tests/no-pre-push branch from 328525b to 2004350 Oct 18, 2017
@diracdeltas
Copy link
Member Author

diracdeltas commented Oct 18, 2017

@bsclifton done!

@luixxiul luixxiul added this to the Backlog milestone Oct 26, 2017
@bbondy
bbondy approved these changes Oct 26, 2017
@bbondy
bbondy approved these changes Oct 26, 2017
@bbondy bbondy merged commit 327382d into master Oct 26, 2017
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
bbondy added a commit that referenced this pull request Oct 26, 2017
remove unittest from pre-push hook
bbondy added a commit that referenced this pull request Oct 26, 2017
remove unittest from pre-push hook
bbondy added a commit that referenced this pull request Oct 26, 2017
remove unittest from pre-push hook
@luixxiul luixxiul modified the milestones: Backlog, 0.19.x Hotfix 3 (Release channel) Oct 28, 2017
@bsclifton bsclifton deleted the tests/no-pre-push branch Oct 29, 2017
Copy link
Member

bsclifton left a comment

++ 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

6 participants
You can’t perform that action at this time.