Skip to content
This repository has been archived by the owner. It is now read-only.

remove unittest from pre-push hook #11084

Merged
merged 1 commit into from Oct 26, 2017
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

@@ -26,6 +26,7 @@
"flow": "flow; test $? -eq 0 -o $? -eq 2",
"lint": "standard",
"postinstall": "npm run download-sync-client && webpack",
"pre-push-tests": "if [ -z $NO_PUSH_TESTS ]; then npm run unittest; fi",
"start-log": "node ./tools/start.js --user-data-dir-name=brave-development --enable-logging=stderr --v=1 --enable-extension-activity-logging --enable-sandbox-logging --enable-dcheck",
"start": "node ./tools/start.js --user-data-dir-name=brave-development --enable-logging --v=0 --enable-extension-activity-logging --enable-sandbox-logging --enable-dcheck",
"start2": "node ./tools/start.js --user-data-dir-name=brave-development-2 --enable-logging --v=0 --enable-extension-activity-logging --enable-sandbox-logging --enable-dcheck",
@@ -225,7 +226,7 @@
"pre-push": {
"run": [
"lint",
"unittest"
"pre-push-tests"
]
},
"engines": {
@@ -3,7 +3,7 @@
* You can obtain one at http://mozilla.org/MPL/2.0/. */

module.exports = [
'pre-comit',
'pre-commit',

This comment has been minimized.

Copy link
@luixxiul

luixxiul Sep 30, 2017

Contributor

I've been not sure if this was a typo: #9690 (comment)

This comment has been minimized.

Copy link
@diracdeltas

diracdeltas Oct 10, 2017

Author Member

cc @NejcZdovc on whether this is a typo

This comment has been minimized.

Copy link
@bbondy

bbondy Oct 26, 2017

Member

These are sub-dirs of node_modules mostly so yes it's a typo. Thx.

'pre-push',
'test/',
'docs/',
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.