This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMove the switch wrappers 1rem left #11368
Merged
Conversation
|
To merger: please do not forget to merge this commit to |
codecov-io
commented
Oct 8, 2017
•
Codecov Report
@@ Coverage Diff @@
## 0.20.x #11368 +/- ##
==========================================
- Coverage 50.73% 50.69% -0.04%
==========================================
Files 248 248
Lines 23598 23598
Branches 3872 3872
==========================================
- Hits 11972 11963 -9
- Misses 11626 11635 +9
|
|
|
||
| // TODO: Remove this when #10913 is merged to master | ||
| position: 'relative', | ||
| left: '1rem' |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
luixxiul
Oct 9, 2017
•
Author
Contributor
it's a magic number. It should work for now on 0.19 and 0.20. It'll be removed since 0.21 so an exact calculation is not needed as far as it works.
This comment has been minimized.
This comment has been minimized.
| @@ -365,8 +369,10 @@ const styles = StyleSheet.create({ | |||
| // History and settings icons | |||
| switchWrap__mainIconsRight: { | |||
| position: 'relative', | |||
| right: '12px', | |||
| top: '3.5px' | |||
| top: '3.5px', | |||
This comment has been minimized.
This comment has been minimized.
cezaraugusto
Oct 9, 2017
Contributor
I know it was like this before does but this extra .5px makes any difference?
This comment has been minimized.
This comment has been minimized.
luixxiul
Oct 9, 2017
Author
Contributor
I remember I used a screen ruler and adding it made it look nicer a bit.
|
++ |
cezaraugusto
added a commit
that referenced
this pull request
Oct 9, 2017
Move the switch wrappers 1rem left
This was referenced Oct 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
luixxiul commentedOct 8, 2017
•
edited
This is required for
0.19.xand0.20.xonly for now.Fixes #11367
Auditors:
Test Plan:
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests