This repository was archived by the owner on Dec 11, 2019. It is now read-only.
block access to fingerprinting methods pulled from child frames issue #11683 - #11708
Merged
Conversation
diracdeltas
self-requested a review
October 27, 2017 23:08
luixxiul
added
feature/shields
security
release/blocking
and removed
release/blocking
labels
diracdeltas
reviewed
Oct 30, 2017
| return proxyObject() | ||
| } | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
minor: line ends in whitespace
diracdeltas
approved these changes
Oct 30, 2017
…test for same, issue #11683
Codecov Report
@@ Coverage Diff @@
## master #11708 +/- ##
==========================================
- Coverage 52.01% 51.98% -0.04%
==========================================
Files 269 269
Lines 25534 25534
Branches 4069 4069
==========================================
- Hits 13282 13273 -9
- Misses 12252 12261 +9
|
Contributor
Author
|
@diracdeltas fixed the white space issue (and removed the semicolons, I know you all don't use them), and re-squashed. I think this should be good, as far as I know |
bbondy
added a commit
that referenced
this pull request
Oct 31, 2017
block access to fingerprinting methods pulled from child frames issue #11683
bbondy
added a commit
that referenced
this pull request
Oct 31, 2017
block access to fingerprinting methods pulled from child frames issue #11683
bbondy
added a commit
that referenced
this pull request
Oct 31, 2017
block access to fingerprinting methods pulled from child frames issue #11683
bbondy
modified the milestones:
0.19.x Hotfix 3 (Release channel),
0.19.x Hotfix 4 (Release channel)
Member
|
Sorry but I had to revert this because of #11751 |
Contributor
Author
|
Sounds good, will do. If the new proposed / amended approach (a counter to limit an infinite recursion) sounds good, I’ll re-PR.
… On Nov 1, 2017, at 20:18, Brian R. Bondy ***@***.***> wrote:
Sorry but I had to revert this because of #11751
Please do a new pull request for this when that one is addressed. I moved it into 0.19.x hotfix 4.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
bbondy
modified the milestones:
0.19.x Hotfix 5 (Release channel),
0.19.x Hotfix 4 (Release channel)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@diracdeltas
This PR fixes #11683. The fix is a little funky, since it requires injecting JS into child pages (the
chrome.webFrame.setGlobalmethod wont work here, since we need to call toObject.definePropery) but it should be good.Added a
blocking access to fingerprinting methods on iframe.contentWindowtest to test that things are actually getting blocked