Skip to content
This repository has been archived by the owner. It is now read-only.

Changed "Never include" message on payments page. Fix #12296 #12960

Merged

Conversation

@MargarytaChepiga
Copy link
Collaborator

commented Jan 31, 2018

Changed the string from "Never include this site" to "Never include this content creator".
You can find the issue here.
Fix #12296

Before:

brave_fix_before

After:

brave_fix

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header
@NejcZdovc NejcZdovc self-requested a review Jan 31, 2018
@NejcZdovc NejcZdovc added this to the 0.20.x Hotfix 2 milestone Jan 31, 2018
@codecov-io

This comment has been minimized.

Copy link

commented Jan 31, 2018

Codecov Report

Merging #12960 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12960      +/-   ##
==========================================
- Coverage   56.14%    56.1%   -0.04%     
==========================================
  Files         279      279              
  Lines       27326    27326              
  Branches     4443     4443              
==========================================
- Hits        15341    15332       -9     
- Misses      11985    11994       +9
Flag Coverage Δ
#unittest 56.1% <ø> (-0.04%) ⬇️
Impacted Files Coverage Δ
js/stores/appStoreRenderer.js 91.66% <0%> (-8.34%) ⬇️
app/renderer/components/reduxComponent.js 84.61% <0%> (-6.16%) ⬇️
js/stores/windowStore.js 27.69% <0%> (-0.3%) ⬇️
@MargarytaChepiga

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 31, 2018

I have noticed that tests are not passing for some reason, is there something I can do to fix it?

@alexwykoff alexwykoff modified the milestones: 0.20.x Hotfix 3 (Ledger improvments), 0.21.x (Beta Channel) Feb 6, 2018
Copy link
Member

left a comment

Looks good to me. Thank you for you contribution and congrats on your first contribution 🎉 If you need any help with anything else let me know

@NejcZdovc NejcZdovc merged commit 821c0b6 into brave:master Feb 7, 2018
1 of 3 checks passed
1 of 3 checks passed
codecov/project 56.1% (-0.04%) compared to 94e5e15
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
codecov/patch Coverage not affected when comparing 94e5e15...a944bf6
Details
NejcZdovc added a commit that referenced this pull request Feb 7, 2018
…nts-issue

Changed "Never include" message on payments page. Fix #12296
@NejcZdovc

This comment has been minimized.

Copy link
Member

commented Feb 7, 2018

master 821c0b6
0.22 0b63045
0.21 49cc628

NejcZdovc added a commit that referenced this pull request Feb 7, 2018
…nts-issue

Changed "Never include" message on payments page. Fix #12296
@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Beta Channel), 0.21.x (Twitch) Feb 24, 2018
@NejcZdovc

This comment has been minimized.

Copy link
Member

commented Feb 24, 2018

0.21 twitch ce127d1

NejcZdovc added a commit that referenced this pull request Feb 24, 2018
…nts-issue

Changed "Never include" message on payments page. Fix #12296
@srirambv

This comment has been minimized.

Copy link
Collaborator

commented Feb 27, 2018

This is broken on 0.21.16
12960

@NejcZdovc

This comment has been minimized.

Copy link
Member

commented Feb 27, 2018

@srirambv which language are you using? This was fixed only on en-US, other translations were probably not added yet.

@srirambv

This comment has been minimized.

Copy link
Collaborator

commented Feb 27, 2018

Yeah works on en-US. Mine defaults to en-UK

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.