This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUsing RenderFrameHost::CopyImageAt for image copy #13108
Merged
Conversation
fix #7388 Auditors: @bbondy, @bsclifton Test Plan: 1. Go to https://www.brave.com/about/images/brave_icon_512x.png 2. Click "Copy Image" from context menu 3. The image should be copied to your clipboard instead of url 4. Paste it to somewhere else like slack channel to verify
codecov-io
commented
Feb 12, 2018
•
Codecov Report
@@ Coverage Diff @@
## master #13108 +/- ##
==========================================
+ Coverage 56.31% 56.33% +0.02%
==========================================
Files 280 278 -2
Lines 27591 27561 -30
Branches 4499 4498 -1
==========================================
- Hits 15537 15526 -11
+ Misses 12054 12035 -19
|
|
This works great, I verified that an image is copied at it's 'natural' size rather than its rendered size, which is perfect |
|
Just a note that when cherry-picking to 0.20.x, even though there will not be a merge error, we will need to change |
petemill
added a commit
that referenced
this pull request
Feb 12, 2018
Using RenderFrameHost::CopyImageAt for image copy
petemill
added a commit
that referenced
this pull request
Feb 12, 2018
Using RenderFrameHost::CopyImageAt for image copy
petemill
added a commit
that referenced
this pull request
Feb 12, 2018
Using RenderFrameHost::CopyImageAt for image copy
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
darkdh commentedFeb 12, 2018
fix #7388
Auditors: @bbondy, @bsclifton
Test Plan:
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests