Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Made urlBarIconContainer clickable to display connection info. Fix #7888 #13147
I also touched some css, changed few things that had a TODO. In addition to changing a little bit of styling.
@@ Coverage Diff @@ ## master #13147 +/- ## ========================================== - Coverage 56.3% 56.26% -0.04% ========================================== Files 278 278 Lines 27585 27584 -1 Branches 4497 4497 ========================================== - Hits 15531 15521 -10 - Misses 12054 12063 +9
Works great ++.
@MargarytaChepiga would it be possible to add the separator after the lock icon for sites that do not show the EVC
The reason being as per test plan it says click around edges to see view certificate modal is shown but where EVC is not shown there is no edge on the right side so having the separator would make it clickable within that area
@bsclifton what do you think?