sync v2 #13197

cezaraugusto · 2018-02-20T02:59:57Z

Closes #12269
Closes #9254
Closes #12356

Test Plan:

Run npm start and npm run start2 so you can sync between devices
You should be able to copy passphrase content using the clipboard button
You should be able to Sync two devices by typing the correct passphrase
Passphrase should have a counter and it should match the number of words (current default 16)
Once you sync both devices, they should appear in the postSetup content (inside sortableTable)

Note for reviewers: There's a bug reported in #13258 where you can't sync devices again once you reset sync. That will be tracked separately so in case you're testing multiple options, ensure to clear your profile after every reset you want.

Screenshots UPDATED:

diracdeltas · 2018-02-26T17:45:17Z

app/extensions/brave/locales/en-US/preferences.properties

@@ -347,10 +363,15 @@ syncResetMessageOtherDevices=If you've synced other devices, they will continue
 syncResetMessageWhat=Resetting Sync clears data stored on the Sync server and resets this device's Sync settings.
 syncResetMessageWhatNot=You will keep any bookmarks, history and other browsing data currently on this device.
 syncRetryButton=Try again
+syncScan=Scan the code
+syncWelcome1=Brave Sync allows you to sync bookmarks, tabs, history and other data privately between your Brave Browsers on your varios devices.


diracdeltas · 2018-02-26T17:46:12Z

app/sessionStore.js

@@ -1015,7 +1015,8 @@ module.exports.defaultAppState = () => {
      lastFetchTimestamp: 0,
      objectsById: {},
      pendingRecords: {},
-      lastConfirmedRecordTimestamp: 0
+      lastConfirmedRecordTimestamp: 0,
+      setupCompleted: false


please add this to docs/state.md

diracdeltas · 2018-02-26T17:47:13Z

package.json

-    "run": [
-      "lint",
-      "pre-push-tests"
-    ]


should this have been removed? (btw you can delete the commit hooks in .git/hooks instead so it doesn't change any files that are checked into git)

ya shouldn't be removed. added back

diracdeltas · 2018-02-26T17:54:28Z

is this blocked on #13313?

diracdeltas · 2018-02-26T18:34:43Z

app/renderer/components/preferences/syncTab.js

        return
      }
    }
    window.alert('Invalid input code; please try again or create a new profile.')
  }

  render () {
+    console.log(JSON.stringify(this.props.syncData.get('devices')))


extra console.log

oh noes! fixed

diracdeltas · 2018-02-26T19:23:52Z

UI comments:

It doesn't seem to update the word count (stays at 1 no matter what i type)

If I click 'Start new sync chain' > 'Computer', copy the code, then click 'Done', it still shows the pre-sync preferences screen. Is that expected? It only shows the post-sync screen once another device is synced.

On the post-sync preferences screen, if I click 'Sync a new device..., 'Computer', then click the 'X' button to close the window, it goes back to showing the pre-sync screen. This seems like a bug.

cezaraugusto · 2018-03-01T03:03:34Z

ref #13197 (comment)

It doesn't seem to update the word count (stays at 1 no matter what i type)

I'll fix it. I only tested with copy/paste, which works but should work with any user input

If I click 'Start new sync chain' > 'Computer', copy the code, then click 'Done', it still shows the pre-sync preferences screen. Is that expected? It only shows the post-sync screen once another device is synced.

I'm not sure if I followed right but you can't hit done until you go to the next screen (devices list). If you hit the X (close) button you're expected to go to the start screen. The only way to activate Sync is to hit done on the last screen. (there are changes coming on this after Brad feedback).

On the post-sync preferences screen, if I click 'Sync a new device..., 'Computer', then click the 'X' button to close the window, it goes back to showing the pre-sync screen. This seems like a bug.

Ya that's a bug. Addressed in 260ba3e

cezaraugusto · 2018-03-01T03:04:28Z

removing reviewers and setting as work in progress to apply new UI changes per Brad request


        sync v2

- several UI changes user flow for sync improvements


        mockup sync images in prefs test


        only reset sync if user is not in `setup mode`


        address new design spec


        allow sync devices to be removed

fix #9254 fix #12356


        Add bip39 dependency

@cezaraugusto

Auditors: @cezaraugusto


        bip39 implementation for sync (not ledger)

@cezaraugusto

- Update display of codes to use bip39 - Update input of codes to handle either bip39 or niceware - On recovery (input), only enable button if word length is 16 or 24 First half of implementation for #13313 Auditors: @cezaraugusto


        remove global scope from niceware


        refactor sync to use brave-crypto

fix #13782


        split passphrase into words for test

@cezaraugusto

auditors: @cezaraugusto


        replace *sync'd* with *synced*


        add mainDevice to state docs


        add passphrase warning

cezaraugusto · 2018-04-10T22:05:34Z

reviews request addressed, left a question regarding seed but per #13197 (review) that's a non-blocker.

Screenshots for passphrase warning added in #13197 (comment). We're ready for a re-review

diracdeltas · 2018-04-10T22:19:00Z

@cezaraugusto looks good but the QR code is also private and should show a warning on this screen


        add qrcode warning

cezaraugusto · 2018-04-11T15:07:13Z

Added notice for QR code screen per #13197 (comment):

Phrase is the same as other screens cc @bradleyrichter if this one needs adjustment


        0.22.1

diracdeltas · 2018-04-11T17:13:41Z

js/stores/appStore.js

@@ -563,6 +565,9 @@ const handleAppAction = (action) => {
        if (device.name) {
          appState = appState.setIn(['sync', 'devices', deviceId, 'name'], device.name)
        }
+        if (!hasMainDevice && getSetting(settings.SYNC_DEVICE_NAME) === device.name) {


i think this line just sets the mainDevice to be true for any device with the same name as the current device, since SYNC_DEVICE_NAME is the name of the current device. is that the intended behavior?

(as long as the current device doesn't know of any existing main devices)

diracdeltas

looks good! two follow up issues:

brave/sync#201
brave/sync#202

bsclifton · 2018-06-18T07:06:44Z

Great job on this PR - I know you've already shifted work towards Brave Core. I captured what has been done so far with brave/brave-browser#356 for when we do chose to implement this 😄

cezaraugusto self-assigned this Feb 20, 2018

cezaraugusto added PR/work-in-progress ⚒ feature/sync labels Feb 20, 2018

cezaraugusto added this to the 0.21.x (Beta Channel) milestone Feb 20, 2018

alexwykoff modified the milestones: 0.21.x (Beta Channel), 0.22.x (Developer Channel) Feb 20, 2018

cezaraugusto force-pushed the sync/v2/12269 branch 3 times, most recently from 25e4a30 to 75c689d Feb 22, 2018

cezaraugusto requested review from ayumi, diracdeltas and bsclifton Feb 22, 2018

cezaraugusto added PR/needs-QA-attention ☕ initiative/sync and removed PR/work-in-progress ⚒ labels Feb 22, 2018

cezaraugusto requested review from bradleyrichter and alexwykoff Feb 22, 2018

cezaraugusto mentioned this pull request Feb 22, 2018

after sync reset, devices are not visible anymore if you try to re-sync #13258

Closed

bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018

diracdeltas reviewed Feb 26, 2018

View changes

cezaraugusto mentioned this pull request Mar 1, 2018

Add remove function for any single device in sync chain #13047

Closed

0 of 10 tasks complete

cezaraugusto force-pushed the sync/v2/12269 branch from 75c689d to 4eda8cd Mar 1, 2018

Cezar Augusto and others added 13 commits Feb 22, 2018

sync v2

Unverified

The email in this signature doesn’t match the committer email.

GPG key ID: ECC5FF1C7EA1D39D Learn about signing commits

a1c0d9f

- several UI changes user flow for sync improvements

mockup sync images in prefs test

Unverified

The email in this signature doesn’t match the committer email.

GPG key ID: ECC5FF1C7EA1D39D Learn about signing commits

1f16ca6

only reset sync if user is not in `setup mode`

Unverified

The email in this signature doesn’t match the committer email.

GPG key ID: ECC5FF1C7EA1D39D Learn about signing commits

61c8577

address new design spec

Unverified

The email in this signature doesn’t match the committer email.

GPG key ID: ECC5FF1C7EA1D39D Learn about signing commits

a42ff23

allow sync devices to be removed

Unverified

The email in this signature doesn’t match the committer email.

GPG key ID: ECC5FF1C7EA1D39D Learn about signing commits

bf2990b

fix #9254 fix #12356

Add bip39 dependency

Unverified

The email in this signature doesn’t match the committer email.

GPG key ID: ECC5FF1C7EA1D39D Learn about signing commits

764b09b

Auditors: @cezaraugusto

remove global scope from niceware

Unverified

The email in this signature doesn’t match the committer email.

GPG key ID: ECC5FF1C7EA1D39D Learn about signing commits

f8cc3d2

refactor sync to use brave-crypto

Unverified

The email in this signature doesn’t match the committer email.

GPG key ID: ECC5FF1C7EA1D39D Learn about signing commits

3e9365c

fix #13782

split passphrase into words for test

Unverified

The email in this signature doesn’t match the committer email.

GPG key ID: ECC5FF1C7EA1D39D Learn about signing commits

23cf563

auditors: @cezaraugusto

replace *sync'd* with *synced*

Unverified

The email in this signature doesn’t match the committer email.

GPG key ID: ECC5FF1C7EA1D39D Learn about signing commits

ef16e81

add mainDevice to state docs

Unverified

The email in this signature doesn’t match the committer email.

GPG key ID: ECC5FF1C7EA1D39D Learn about signing commits

f592805

add passphrase warning

Unverified

The email in this signature doesn’t match the committer email.

GPG key ID: ECC5FF1C7EA1D39D Learn about signing commits

Loading status checks…

9b27f97

cezaraugusto force-pushed the sync/v2/12269 branch from fda5078 to 9b27f97 Apr 10, 2018

add qrcode warning

Unverified

The email in this signature doesn’t match the committer email.

GPG key ID: ECC5FF1C7EA1D39D Learn about signing commits

Loading status checks…

a1865b2

cezaraugusto mentioned this pull request Apr 11, 2018

Sometimes data is not cleared in sync after leaving sync chain #13799

Closed

0.22.1

Loading status checks…

3ba5860

diracdeltas reviewed Apr 11, 2018

View changes

diracdeltas approved these changes Apr 11, 2018

View changes

bsclifton modified the milestones: 0.23.x (Developer Channel), 0.24.x (Nightly Channel) May 1, 2018

bsclifton mentioned this pull request Jun 18, 2018

Implement Sync UI #356

Closed

bsclifton closed this Jun 18, 2018

bsclifton removed this from the 0.24.x (Developer Channel) milestone Jun 18, 2018

bsclifton deleted the sync/v2/12269 branch Aug 18, 2018

cezaraugusto mentioned this pull request Nov 13, 2018

Implement Sync v2 #2123

Closed

0 of 5 tasks complete

brave / browser-laptop Archived

sync v2 #13197

sync v2 #13197

cezaraugusto commented Feb 20, 2018 •

edited

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

diracdeltas commented Feb 26, 2018

This comment has been minimized.

This comment has been minimized.

diracdeltas commented Feb 26, 2018

cezaraugusto commented Mar 1, 2018 •

edited

cezaraugusto commented Mar 1, 2018

cezaraugusto commented Apr 10, 2018

diracdeltas commented Apr 10, 2018

cezaraugusto commented Apr 11, 2018

This comment has been minimized.

This comment has been minimized.

diracdeltas left a comment

bsclifton commented Jun 18, 2018

brave / browser-laptop Archived

Join GitHub today

sync v2 #13197

sync v2 #13197

Conversation

cezaraugusto commented Feb 20, 2018 • edited

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

diracdeltas commented Feb 26, 2018

This comment has been minimized.

This comment has been minimized.

diracdeltas commented Feb 26, 2018

cezaraugusto commented Mar 1, 2018 • edited

cezaraugusto commented Mar 1, 2018

cezaraugusto commented Apr 10, 2018

diracdeltas commented Apr 10, 2018

cezaraugusto commented Apr 11, 2018

This comment has been minimized.

This comment has been minimized.

diracdeltas left a comment

bsclifton commented Jun 18, 2018

cezaraugusto commented Feb 20, 2018 •

edited

cezaraugusto commented Mar 1, 2018 •

edited