Skip to content
This repository has been archived by the owner. It is now read-only.

Fixes object scenario for uint #13201

Merged
merged 1 commit into from Feb 20, 2018
Merged

Conversation

@NejcZdovc
Copy link
Member

NejcZdovc commented Feb 20, 2018

Resolves #13183

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Clean profile
Enable payments
Close browser
Start browser
Make sure that everything is ok and there is no errors in the console

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header
Resolves #13183

Auditors:

Test Plan:
@NejcZdovc NejcZdovc added this to the 0.21.x (Beta Channel) milestone Feb 20, 2018
@NejcZdovc NejcZdovc self-assigned this Feb 20, 2018
@NejcZdovc NejcZdovc requested a review from bsclifton Feb 20, 2018
@NejcZdovc NejcZdovc mentioned this pull request Feb 20, 2018
8 of 10 tasks complete
@codecov-io
Copy link

codecov-io commented Feb 20, 2018

Codecov Report

Merging #13201 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #13201      +/-   ##
==========================================
- Coverage   56.27%   56.23%   -0.04%     
==========================================
  Files         282      282              
  Lines       28027    28027              
  Branches     4584     4585       +1     
==========================================
- Hits        15772    15761      -11     
- Misses      12255    12266      +11
Flag Coverage Δ
#unittest 56.23% <100%> (-0.04%) ⬇️
Impacted Files Coverage Δ
app/browser/api/ledger.js 60.29% <100%> (-0.1%) ⬇️
js/stores/appStoreRenderer.js 91.66% <0%> (-8.34%) ⬇️
app/renderer/components/reduxComponent.js 57.75% <0%> (-3.45%) ⬇️
js/stores/windowStore.js 27.65% <0%> (-0.3%) ⬇️
@NejcZdovc NejcZdovc removed the request for review from bsclifton Feb 20, 2018
Copy link
Member

bsclifton left a comment

++

@bsclifton bsclifton merged commit a8844a5 into brave:master Feb 20, 2018
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
codecov/patch 100% of diff hit (target 56.27%)
Details
codecov/project Absolute coverage decreased by -0.03% but relative coverage increased by +43.72% compared to 64d434a
Details
bsclifton added a commit that referenced this pull request Feb 20, 2018
Fixes object scenario for uint
bsclifton added a commit that referenced this pull request Feb 20, 2018
Fixes object scenario for uint
@bsclifton
Copy link
Member

bsclifton commented Feb 20, 2018

master a8844a5
0.22.x de57a17
0.21.x 56023cb

@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Beta Channel), 0.21.x (Twitch) Feb 24, 2018
NejcZdovc added a commit that referenced this pull request Feb 24, 2018
Fixes object scenario for uint
@NejcZdovc
Copy link
Member Author

NejcZdovc commented Feb 24, 2018

0.21 twitch 0ed0e1e

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.