Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

[WIP] Credit card numeric and length validation with credit card icon proof-of-concept. #13737

Closed
wants to merge 11 commits into from

Conversation

MargarytaChepiga
Copy link
Contributor

@MargarytaChepiga MargarytaChepiga commented Apr 5, 2018

For issue#3370
This is still work in progress. I have done some progress, but I am not sure if I am on the right track. I would really appreciate some feedback and/or suggestions 😄
What is done:

  • numeric & length validation ( generic one and for some specific types )
  • credit card icon ( only for those which are available for free at font awesome )

Some screenshots:
Icons:
pr1
Validations:
pr_checking validations

UI changes when adding a card are just for debugging purposes.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc
Copy link
Contributor

cc @bsclifton @bradleyrichter for your inputs

@codecov-io
Copy link

codecov-io commented Apr 11, 2018

Codecov Report

Merging #13737 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13737      +/-   ##
==========================================
+ Coverage   56.53%   56.57%   +0.03%     
==========================================
  Files         282      282              
  Lines       28747    28790      +43     
  Branches     4764     4773       +9     
==========================================
+ Hits        16253    16288      +35     
- Misses      12494    12502       +8
Flag Coverage Δ
#unittest 56.57% <ø> (+0.03%) ⬆️
Impacted Files Coverage Δ
...rer/components/preferences/payment/deletedSites.js 41.02% <0%> (-7.46%) ⬇️
app/renderer/components/preferences/paymentsTab.js 68.27% <0%> (-2.95%) ⬇️
app/sessionStore.js 87.79% <0%> (-0.62%) ⬇️
...erer/components/preferences/payment/ledgerTable.js 85.71% <0%> (-0.42%) ⬇️
app/common/state/ledgerState.js 85.19% <0%> (+0.24%) ⬆️
js/lib/urlutil.js 86.83% <0%> (+0.43%) ⬆️
app/browser/api/ledger.js 62.43% <0%> (+0.5%) ⬆️

@bsclifton
Copy link
Member

Apologies that we haven't had time to do a proper review or work on closing this ☹️

I'm going to close the PR for now. Given that we'll be switching over to Brave Core in the next few months, I don't think it would make sense to address this issue now

Thanks for putting in the effort for this though- it's definitely appreciated 😄

@bsclifton bsclifton closed this Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants