This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
[WIP] Credit card numeric and length validation with credit card icon proof-of-concept. #13737
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terCard, american exprss and discover.
cc @bsclifton @bradleyrichter for your inputs |
… have an icon for)
…terCard, american exprss and discover.
… have an icon for)
…e credit card types. Fixes brave#3370
Codecov Report
@@ Coverage Diff @@
## master #13737 +/- ##
==========================================
+ Coverage 56.53% 56.57% +0.03%
==========================================
Files 282 282
Lines 28747 28790 +43
Branches 4764 4773 +9
==========================================
+ Hits 16253 16288 +35
- Misses 12494 12502 +8
|
Apologies that we haven't had time to do a proper review or work on closing this I'm going to close the PR for now. Given that we'll be switching over to Brave Core in the next few months, I don't think it would make sense to address this issue now Thanks for putting in the effort for this though- it's definitely appreciated 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue#3370
This is still work in progress. I have done some progress, but I am not sure if I am on the right track. I would really appreciate some feedback and/or suggestions 😄
What is done:
Some screenshots:
Icons:
Validations:
UI changes when adding a card are just for debugging purposes.
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests