Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixes URL Parsing failing for query string and file name with space #13898
Screenshots of fixes
@diracdeltas I'm trying to rebase these commits after pulling the latest additions from the master branch of this project and resolved all conflicts.
I've rebased all of my own commits, but now I'm running into a lot of conflicts as it attempts to rebase commits that are before mine. I've tried skipping a few, but other files are also showing conflicts, thus I've stopped the process to gain more clarification.
I'm new to rebasing so I don't want to mess up the original code base. Currently I'm performing rebase on my own branch so I think I have at least that part correct (please correct me if I am not).
Would you please provide me with some guidance on how to proceed?
Here's the log.
Thanks @NejcZdovc. I've now squashed and rebased my commits. However, I'm noticing that a urlutil test is not passing.
Error seems to be coming from
Yet, this attempt at guessing what the problem may be does not provide me with any clues on how to solve this problem.
Any thoughts on this?
* Added tests to ensure Windows file path works * Added tests to ensure Unix aboslute path works * Added test to ensure entering http://www.google.ca/search?q=dog cat results in proper google search of "dog cat" * Added test case to ensure isNotURL() returns true when the input is a pure query string Fixes #13897 Auditors: * NejcZdovc * diracdeltas * bsclifton Test Plan: * run test on urlutil by executing: npm test -- --grep="urlutil" * Type in address bar: C:\path\to\file should show file:///c:/path/to/file * Type in address bar C:\path\to\file\with space should show file:///C:/path/to/file/with%20space * Type in address bar http://www.google.ca/search?q=dog cat should result in a google search of "dog cat"