This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdds a session selector to bookmark dialog #14185
Closed
+14,123
−9,902
Conversation
…there are no publishers in the ledger table.
Adds s-s to the referral code
Block empty containers
Fix #13689 This bug was caused because menu items were using a hidden window for their new tabs. We should _not_ use `electron{.remote}.BrowserWindow.getAllWindows()` or `.get{Active, Focused}Window` directly. There are two reasons that could have bad results: 1. We create BrowserWindows which are not normal tabbed renderer windows (e.g. some code that runs on Bookmark creation) 2. We have a hidden window sometimes (the Buffer Window) Instead call `app/browser/window.js`: `getAllRendererWindows` and `getActiveWindowId`. Fix for main menu actions, which can be called when there are no windows, but when searching for `BrowserWindow.` Test Plan: - Check all menu items open new tab in currently active window - Check all menu items open new tab in currently active window, when app is not focused - Check all menu items open new tab in new window if there is no visible window - Check tabs in all windows are persisted on restart when app / windows close - Check process quits in Windows when last visible window is closed
Menu items which need a window will create / show one if needed
Fix #13695 Remove usage of textCalc as it was the last usage of tabs.executeScriptInBackground which is not compatible with upcoming muon v6.x since as it incorrectly used executeScriptInTab which should only work on a WebContents which is a Tab, not a Window. Muon does not have a generic WebContents.executeJavascript method. Also added bonus of not requiring creating new Windows in order to calculate text width and having to manage when they are closed, etc which should address the following issues, if that was the cause: Fix #13422 Fix #13277
Calculate bookmarks bar overflow using css
fix #12671 test plan: 1. download an image and name it to rabbits.jpg 2. in the rabbits.jpg directory, start a localhost server: 'python -m SimpleHTTPServer 8000' 3. go to https://jsfiddle.net/c6y5qx5m/. you should see either 2 or 3 copies of rabbits.jpg loaded. 4. go to about:preferences#security and enable 'Application Firewall' 5. go to https://jsfiddle.net/c6y5qx5m/ in a new private or session tab (to avoid loading cached files). now none of the rabbits.jpg images should load.
add off-by-default application firewall feature
fix #13668 Test Plan: 1. go to about:preferences#advanced 2. at the bottom, it should show a webrtc policy select menu which defaults to 'default' 3. turn on fingerprinting protection to 'block all' 4. go to https://browserleaks.com/webrtc. it should not show any IPs 5. turn off fingerprinting protection on that page. now it should show IPs 6. in about:preferences#advanced, set webrtc policy to 'default public interface only' 7. reload https://browserleaks.com/webrtc. it should only show the public IP. 8. in about:preferences#advanced, set webrtc policy to 'disable non-proxied UDP' 9. reload https://browserleaks.com/webrtc. it should show no IPs. 10. in about:preferences#advanced, set webrtc policy to 'default public and private interfaces' 11. reload https://browserleaks.com/webrtc. it should show both IPs.
Reconcile is no longer triggered if there are no publishers in the ledger table.
Adds PDF's to the ledger table
Fixes formatting for YT on shields page
add advanced webrtc IP handling preference
Release notes for 0.22.x Release 2
Move webrtc options from advanced to security prefs
Release notes for 0.22.x Release 2
Fixes #12937 Auditors: @hasufell, @NejcZdovc
Update documentation for `Running Brave`
Fixes #12636 Auditors: @cezaraugusto Test Plan: 1. Merge code 2. Re-push latest beta (`browser-laptop-release-linux` job in linux with `beta` param) 3. Re-push latest release (`browser-laptop-release-linux` job in linux with `release` param) 4. Verify packages are installable on Debian Buster
Add support for Debian Buster
fix: Ensure that only "What do these policies mean" is clickable and the entire row
Fixed recovery overlay showing invalid amount before completion
Change facebook top tile to github and improve styling of top tiles icons
Fixes sortTable default sort
address #8956 - this changes the options order from allow/deny to deny/allow to match other notifcations
autoplay notification should follow spec
Travis job optimisations
ishanrp
changed the title
ishanrp
changed the title
ishanrp
changed the title
|
Thanks for the patch, @ishanrp! Sorry that we weren't able to review this in a timely manner |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
and others
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ishanrp commentedMay 20, 2018
Fixes #7417
Adds a session selector to the add/edit bookmark dialog. When opened in a new tab the bookmark will be opened in the selected session.
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Adding using context menu
Result: Opening the bookmark in new tab should open in the selected session.
Using star to instant add
Result: Opening the bookmark in new tab should open it in the respective session.
Editing the bookmark
Result: Opening the bookmark in new tab should open in the selected session.
Reviewer Checklist:
Tests