Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Always show URL bar. closes #1984 #2038

Merged
merged 1 commit into from
Jun 6, 2016
Merged

Always show URL bar. closes #1984 #2038

merged 1 commit into from
Jun 6, 2016

Conversation

cezaraugusto
Copy link
Contributor

diracdeltas
diracdeltas reviewed Jun 3, 2016
View reviewed changes
app/extensions/brave/locales/en-US/preferences.properties
@@ -77,3 +77,4 @@ alwaysAllow=Always allow
alwaysDeny=Always deny
appearanceSettings=Appearance settings
autoHideMenuBar=Hide the menu bar by default
disableTitleMode=Disable Title Mode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure people will know what 'Title Mode' is. Maybe change the text to 'Always show URL bar'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diracdeltas I agree with you, haven't found a better name for it, so I just copied from the issue.

Should I change only i10n and keep everything else as disableTitleMode or change everything to showUrlBar instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine to just change the l10n string

@diracdeltas
Copy link
Member

otherwise looks good to me. thanks!

@bbondy
Copy link
Member

bbondy commented Jun 4, 2016

Looking great!

Please remove the localization files other than English. They are generated only and downloaded from
Transifex. Then you can modify the commit with git rebase -i HEAD~2, or just squash it all together with git rebase -i master.

@bradleyrichter will be excited because he was just asking for this.

You can also set the default to: process.platform === 'win32' to avoid us having 3 titles on Windows until we can get rid of the titlebar. It is @bradleyrichter 's preference on Windows.

@bsclifton
Copy link
Member

bsclifton commented Jun 5, 2016 •
edited
Loading

Love this change (just pulled and tested it; Windows 10, x64). LGTM (pending @bbondy's feedback)! 😄

@bsclifton bsclifton changed the title disable title mode. closes #1984 Always show URL bar. closes #1984 Jun 5, 2016
@cezaraugusto
Copy link
Contributor Author

hope it's all good now 👯

@bbondy
Copy link
Member

bbondy commented Jun 6, 2016

looks great, thank you!

@bbondy bbondy merged commit ac97957 into brave:master Jun 6, 2016
@luixxiul luixxiul added this to the 0.10.4dev milestone Jun 6, 2016
@cezaraugusto cezaraugusto deleted the feature-disable-title-mode branch July 3, 2016 06:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.4dev
Development

Successfully merging this pull request may close these issues.
5 participants
@cezaraugusto @diracdeltas @bbondy @bsclifton @luixxiul