Skip to content
This repository has been archived by the owner. It is now read-only.

animation for tab previews. Closes #2641 #2644

Merged
merged 1 commit into from Jul 21, 2016
Merged

animation for tab previews. Closes #2641 #2644

merged 1 commit into from Jul 21, 2016

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented Jul 21, 2016

Preview:

brave-pr2

@bbondy
Copy link
Member

@bbondy bbondy commented Jul 21, 2016

😮 👍

@bbondy bbondy merged commit c77610d into brave:master Jul 21, 2016
0 of 2 checks passed
@bradleyrichter
Copy link
Contributor

@bradleyrichter bradleyrichter commented Jul 21, 2016

nice! Let me pull and test drive...

@cezaraugusto cezaraugusto deleted the tab-preview-animation branch Jul 21, 2016
@luixxiul luixxiul added this to the 0.11.3dev milestone Jul 22, 2016
@bsclifton
Copy link
Member

@bsclifton bsclifton commented Jul 22, 2016

Very well done! 😄

@bradleyrichter
Copy link
Contributor

@bradleyrichter bradleyrichter commented Jul 22, 2016

Looking great @cezaraugusto. This mostly reduces the somewhat jarring effect when traveling across the tabs which is already a nice improvement.

I did find one issue when it is fading between tabs. The current active tabs appears in the middle. I suspect this is because it is showing through.

Is there any way we could set it up so this doesn't happen? (see screen shots)

image

image

It also seems to pop the new tab preview while fading out the previous. Perhaps adding a fade in for the new tab would solve it?

@cezaraugusto
Copy link
Contributor Author

@cezaraugusto cezaraugusto commented Jul 22, 2016

Hey @bradleyrichter, good catch.

About the current active tab appearing in the middle, there's an issue I'm currently working on, here #142.

About the new tab preview popping, the fade only happens for previews. Maybe tweaking with animation duration and timing-function could fix it. It's currently set as ease-in, maybe ease-out would be better. Will play with to see which fits best 😋 and ask you for feedback, thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants