Skip to content
This repository has been archived by the owner. It is now read-only.

Regression: Text and button on Brave Payment panel are not aligned #4217

Merged
merged 1 commit into from Sep 24, 2016

Conversation

@jkup
Copy link
Contributor

jkup commented Sep 23, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fix #4180

Auditors: @bradleyrichter @luixxiul

Test Plan:

I caused this regression by adding back some top margin to the settingsTitles. We need top margin on them but not when they are inside panel dividers. See the attached image and make sure we don't have the titles pushed down.

@jkup jkup added the design label Sep 23, 2016
@jkup jkup added this to the 0.12.3dev milestone Sep 23, 2016
@luixxiul
Copy link
Contributor

luixxiul commented Sep 23, 2016

LGTM!

@bbondy bbondy merged commit bbf5fc9 into master Sep 24, 2016
0 of 3 checks passed
0 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
@luixxiul luixxiul modified the milestones: 0.12.2dev, 0.12.3dev Sep 24, 2016
@jkup jkup deleted the payment-panel-regression branch Sep 27, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.