Fixes #3730

Auditors:
@bbondy

Test Plan:
1. Make sure you turned on every type of suggestions you want to get via typing from the settings menu and set default Search Engine to duckduckgo
2. Disconnect from internet
3. Start typing something in the url bar

fix #4855

Auditors: @bbondy

Test Plan:
1. Open "about:autofill"
2. Click "Add Address"
3. The save button should be disabled
4. Enter the detail of form, the save button should be enabled
5. Remove all detail of form, the save button should be disabled

1. Open "about:autofill"
2. Click "Add Credit Card"
3. The save button should be disabled
4. Enter the detail of form, the save button should be enabled (Name, Card Number)
5. Remove all detail of form, the save button should be disabled (Name, Card Number)

1. Open "about:autofill"
2. Add address entry
3. Edit the address entry
4. Remove all detail of form, the save button should be disabled

1. Open "about:autofill"
2. Add credit card entry
3. Edit the credit card entry
4. Remove all detail of form, the save button should be disabled (Name, Card Number)

…arks

- sortableTable now allows you to provide a control instead of a string for the header
- about:bookmarks now properly sets tableID (not used yet)
- Adding a new bookmark now requires either a title or location (URL). Required because clicking new bookmark creates an empty object (versus existing buttons which always supply the current page).
- Fixed style issue with about:bookmarks (moved border-right on folderView to organizeView

Fixes #4684
Fixes #4866

Auditors: @jkup, @bbondy

Test Plan:
1. Launch Brave and visit about:bookmarks
2. Pick any folder on the left hand side and click it to select it
3. Click the +folder icon, above the folder view
4. Confirm that the new bookmark folder UI comes up and that it sets the parent folder properly
5. Click add and ensure folder gets added
6. Pick any folder and click it to select
7. In the "title" column, hit the star+ icon to add a new bookmark
8. Confirm you can't add an empty bookmark. Type and see the button enable itself. Delete chars and it disables itself again.
9. Confirm the parent folder is correct and type in a title/url. When done, hit save.
10. Confirm bookmark was added.

Auditors: @aekeus

- make sure that when `message` is a  number (or other non-string type) it is coerced to a string
- same change as what @bridiver did for alerts in #4798, but for confirm dialog

fixes #4883

Also fix crashes for URLs like `data:text/html,<script>alert\(1, 1\)</script>`
and `data:text/html,<script>confirm\(1, 1\)</script>`

Disable save button when no detail present

"New bookmark folder" and "New bookmark" buttons added to about:bookmarks

Update localization

Audtors: @bsclifton

Fix #4817

fix #2826

Auditors: @bridiver, @bbondy

Test Plan:
1. Generate any error pages(connection error, cert error, ...)
2. Clone/Reload should work properly (reload the original URL)

1. Go to any about pages
2. Clone/Reload should work properly (reload the original URL)

Allow about pages to reload and clone

UrlbarSuggestions does not work if you are offline

Start suggestions after first character not second fixes #3235

updated release notes for 0.12.5 RC6

Fixes #4846

Auditors: @bbondy

Test plan:
1. Launch Brave on Windows and set focus to URL bar
2. Press tab to move focus and hit enter
3. Window should not minimize, maximize, or close (focus should have went
to the page)

fix #4903

Auditors: @bbondy

Test Plan:
1. Turn on/off "Always show the URL bar" in about:preferences#general
2. The title mode should work as expected

Do not use default setting when value is false

Caption buttons are no longer tab focusable

Fixes #4909

Auditors: @darkdh

Test Plan:
1. Launch Brave and visit a few sites
2. Visit about:history
3. Double click one of the entries and confirm it opens the location in a new tab

History page now properly opens new tab w/ link that was clicked

Fix Brave crashing on confirm bug

URL input field on the bookmark pulldown disappears

Move bookmark hanger arrow now that reload is on about pages

1. Iterate all urls using the favicon
2. Adjust made-up-favicon condition and override old made-up-favicon url

fix #4882

Auditors: @bridiver, @bbondy

Test Plan:
1. Import bookmarks from firefox on brave 0.12.3
2. Import bookmarks from firefox on brave contains this commit
3. The bookmarks under "Mozilla Firefox" should have favicons

1. Import bookmarks from any browsers
2. The imported bookmarks should have favicons

1. Import bookmarks from html bookmarks file
2. The imported bookmarks should have favicons

Fix #4932

Auditors: @bridiver

fix #2105
requires brave/muon#73

Auditors: @bridiver, @bbondy

Auditors: @alexwykoff

Add whether brave is default browser check

fix #4934

Auditors: @bbondy

Test Plan:
1. Turn off always check on startup
2. Close app
3. Open app
4. Go to preferences
5. Toggle the switch for always check on startup

Delete "defaultBrowserCheckComplete" only when check on startup is on

… display mode

Fixes #4936

Auditors: @bbondy

Test Plan:
1. Launch Brave and open Preferences
2. Verify you can toggle "always show bookmarks toolbar" and not have the drop down above be affected

Split apart "always show bookmarks toolbar" and the bookmarks toolbar display mode

fix #4935

Auditors: @bbondy

Test Plan: N/A

Improve UX of default browser check and Manage Adblock Setting button

Auditors: @bsclifton

Fix #4120

Fix #4954

Import favicon fix:

This reverts commit 878f7c5.

Fix #4913
Fix #4885

Auditors: @bbondy

Test Plan:
1. go to homestarrunner.com and verify that the flash placeholder appears
2. go to http://web.mit.edu/zyan/Public/xframe.html and verify that the iframe is blank
3. open page devtools, load about:preferences, and verify in the Network tab that the `Access-Control-Allow-Origin` response header is not present on about-preferences.html

As of nodejs/node#7941, the node core punycode
module is deprecated.

Auditors: @bbondy

Test Plan: n/a

Fix #4747

Auditors: @bbondy

Test Plan: covered by automated test

Fixes issue where LastPass' popup window is closed during user attempt
to shift focus from username field to password field.

Auditor: @bridiver

BRAVE_IS_DEFAULT_BROWSER for test purpose

fix #4958

Auditors: @bridiver, @bbondy

Test Plan:
1. Make sure there is no session data
2. npm run start/test should not popup the check default browser modal
and overrides brave as default browser.
3. BRAVE_IS_DEFAULT_BROWSER=true npm run start/test should not popup the check default browser modal
and overrides brave as default browser.
4. BRAVE_IS_DEFAULT_BROWSER=false npm run start/test should popup the check default browser modal
and overrides brave not be default browser.

Fixes #4018

default browser check should run only on release build

…cons-to-svg