• "New bookmark folder" and "New bookmark" buttons added to about:bookm…

    bsclifton committed Oct 18, 2016
    …arks
    
    - sortableTable now allows you to provide a control instead of a string for the header
    - about:bookmarks now properly sets tableID (not used yet)
    - Adding a new bookmark now requires either a title or location (URL). Required because clicking new bookmark creates an empty object (versus existing buttons which always supply the current page).
    - Fixed style issue with about:bookmarks (moved border-right on folderView to organizeView
    
    Fixes #4684
    Fixes #4866
    
    Auditors: @jkup, @bbondy
    
    Test Plan:
    1. Launch Brave and visit about:bookmarks
    2. Pick any folder on the left hand side and click it to select it
    3. Click the +folder icon, above the folder view
    4. Confirm that the new bookmark folder UI comes up and that it sets the parent folder properly
    5. Click add and ensure folder gets added
    6. Pick any folder and click it to select
    7. In the "title" column, hit the star+ icon to add a new bookmark
    8. Confirm you can't add an empty bookmark. Type and see the button enable itself. Delete chars and it disables itself again.
    9. Confirm the parent folder is correct and type in a title/url. When done, hit save.
    10. Confirm bookmark was added.