Skip to content
This repository has been archived by the owner. It is now read-only.

URL input field on the bookmark pulldown disappears #4927

Merged
merged 1 commit into from Oct 19, 2016

Conversation

@jkup
Copy link
Contributor

jkup commented Oct 18, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fix #4897

Auditors @luixxiul @bbondy

Test Plan:

To test, make sure that after clicking the star in the URLbar (both on a currently bookmarked and currently not bookmarked page) you can edit both the name and location without the form changing (i.e the location field disappearing)

@jkup jkup added this to the 0.12.6dev milestone Oct 18, 2016
@bbondy
Copy link
Member

bbondy commented Oct 19, 2016

++ thanks!

@bbondy bbondy merged commit fc14b2e into master Oct 19, 2016
0 of 3 checks passed
0 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
@luixxiul
Copy link
Contributor

luixxiul commented Oct 19, 2016

++

@jkup jkup deleted the bookmark-pulldown-disappearing branch Oct 20, 2016
@alexwykoff alexwykoff mentioned this pull request Oct 22, 2016
176 of 178 tasks complete
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.