This repository has been archived by the owner. It is now read-only.
Add validation to siteUtil.updateSiteFavicon (includes tests for each case) #5484
Commits on Nov 8, 2016
-
… case) Properly fixes #4860 Was discovered by @diracdeltas #5445 (comment) Auditors: @diracdeltas Test Plan: 1. Launch Brave and go to bing.com 2. Open a new tab and type "bi" and let autocomplete show "bing.com" 3. Hit enter... and it no longer crashes :)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.