This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfix pinning topSites not respecting position #5645
Merged
Conversation
Auditors: @bsclifton fix #5337 Test Plan: * Access new tab page; * Access 4-6 websites; * Pin a site. Pinning a site should add a Pin icon on top-right corner and be kept on its position (not jump); * Keep in mind the website position and reorder it to a new position; * Access another website and get back to new tab. Ensure that your last pinned website kept its position;
|
LGTM |
This was referenced Nov 21, 2016
|
@srirambv could you open a new issue for that? This is more related to how we define topSites (based on number of visits). On your comment pinned topSites are still on their positions, so slightly different. Thanks!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.

cezaraugusto commentedNov 15, 2016
•
edited
git rebase -ito squash commits (if needed).Auditors: @bsclifton
fix #5337
Test Plan: