Skip to content
This repository has been archived by the owner. It is now read-only.

Fix about:brave; version information is always set (regardless of errors) #5692

Merged
merged 1 commit into from Nov 16, 2016

Conversation

@bsclifton
Copy link
Member

bsclifton commented Nov 16, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Version information is always set (regardless of errors).

Code itself is now fault tolerant as well. Includes tests.

Fixes: #5633

Auditors: @jonathansampson, @bbondy

Manual test plan:

  1. Move your session out of the way (or do a fresh install)
  2. Launch Brave
  3. Go to about:brave
  4. Notice version shows as expected

Automated test plan:
run npm run test -- --grep="about:brave tests"

… is now fault tolerant as well. Includes tests.

Fixes: #5633

Auditors: @jonathansampson, @bbondy

Manual test plan:
1. Move your session out of the way (or do a fresh install)
2. Launch Brave
3. Go to about:brave
4. Notice version shows as expected

Automated test plan:
run `npm run test -- --grep="about:brave tests"`
@jonathansampson
Copy link
Collaborator

jonathansampson commented Nov 16, 2016

LGTM

@bsclifton
Copy link
Member Author

bsclifton commented Nov 16, 2016

BTW- meant to document this; The reason the version wasn't showing:
When the app loads for the first time, the session does not exist. When it tries to load, it fails because it's trying to process undefined.

@bsclifton bsclifton merged commit 8633ebf into brave:master Nov 16, 2016
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@bsclifton bsclifton deleted the bsclifton:about-brave branch Nov 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.