This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix about:brave; version information is always set (regardless of errors) #5692
Conversation
… is now fault tolerant as well. Includes tests. Fixes: #5633 Auditors: @jonathansampson, @bbondy Manual test plan: 1. Move your session out of the way (or do a fresh install) 2. Launch Brave 3. Go to about:brave 4. Notice version shows as expected Automated test plan: run `npm run test -- --grep="about:brave tests"`
|
LGTM |
|
BTW- meant to document this; The reason the version wasn't showing: |
This was referenced Nov 21, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bsclifton commentedNov 16, 2016
git rebase -ito squash commits (if needed).Version information is always set (regardless of errors).
Code itself is now fault tolerant as well. Includes tests.
Fixes: #5633
Auditors: @jonathansampson, @bbondy
Manual test plan:
Automated test plan:
run
npm run test -- --grep="about:brave tests"