Skip to content
This repository has been archived by the owner. It is now read-only.

/ browser-laptop Archived

Speed up ledger startup #6822

Merged
merged 1 commit into from Jan 24, 2017
Merged

Speed up ledger startup #6822

merged 1 commit into from Jan 24, 2017

Conversation

@mrose17
Copy link
Member

mrose17 commented Jan 23, 2017

Auditor: @bsclifton

Test Plan:

  1. LEDGER_LOGGING=true
  2. launch browser with contributions off
  3. verify that no ledger stuff prints out at all
  4. turn on contributions
  5. wait for system to create wallet, etc.
  6. restart browser
  7. verify that at least 3 seconds elapses before ledger code makes network calls
@mrose17 mrose17 added this to the 0.13.1 milestone Jan 23, 2017
@mrose17 mrose17 self-assigned this Jan 23, 2017
@mrose17 mrose17 requested a review from bsclifton Jan 23, 2017
@mrose17 mrose17 added the perf label Jan 23, 2017
@bsclifton bsclifton force-pushed the 0.13.1-ledger-startup branch from 5f515a7 to 6c00c7c Jan 24, 2017
@bsclifton bsclifton changed the base branch from master to 0.13.1-branch Jan 24, 2017
@mrose17 @bsclifton
Low-hanging fruit...
Unverified
This user has not uploaded their public key yet.
GPG key ID: 37FF5F19022427F2 Learn about signing commits
Loading status checks…
56c5870 
- defer loading ledger-* packages until absolutely needed
- defer initial call to client.sync() in order to minimize delay on
startup
@bsclifton bsclifton changed the base branch from 0.13.1-branch to master Jan 24, 2017
@bsclifton bsclifton force-pushed the 0.13.1-ledger-startup branch from 6c00c7c to 56c5870 Jan 24, 2017
@bsclifton bsclifton changed the title 0.13.1 ledger startup Speed up ledger startup Jan 24, 2017
@bsclifton
Copy link
Member

bsclifton commented Jan 24, 2017

I rebased against master instead, since we're going to want to make sure performance is great there 😄 Will give this a go here and report back...
@bsclifton bsclifton modified the milestones: 0.13.0, 0.13.1 Jan 24, 2017
@bsclifton
Copy link
Member

bsclifton commented Jan 24, 2017

Tested on mac + Windows; looks good 😄
@bsclifton bsclifton merged commit 134ad76 into master Jan 24, 2017
0 of 3 checks passed
0 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
@bsclifton bsclifton deleted the 0.13.1-ledger-startup branch Jan 24, 2017
@luixxiul
Copy link
Contributor

luixxiul commented Jan 24, 2017

Please create an associated issue, thanks :-)
@mrose17 mrose17 mentioned this pull request Jan 24, 2017
Closed
@mrose17
Copy link
Member Author

mrose17 commented Jan 24, 2017

Fixes #6833
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton

Assignees

@mrose17 mrose17

Labels
feature/rewards perf
Projects
None yet
Milestone
  0.13.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@mrose17 @bsclifton @luixxiul
You can’t perform that action at this time.