Skip to content
This repository has been archived by the owner. It is now read-only.

Preserve order when exporting bookmarks #7195

Merged
merged 1 commit into from Feb 11, 2017
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Preserve order when exporting bookmarks

fix #7189

Auditors: @bbondy, @NejcZdovc

Test Plan:
1. Import a lot of bookmarks.
2. Export bookmarks to a file. (file A)
3. Delete all the bookmarks
4. Import from file A
5. The bookmarks order should be the same as step 1
  • Loading branch information
darkdh committed Feb 11, 2017
commit 2ee3ee7a3f33b967806a946c06b299fa623bebcd
@@ -52,7 +52,7 @@ function createBookmarkArray (sites, parentFolderId, first = true, depth = 1) {

if (first) payload.push(`${indentFirst}<DL><p>`)

filteredBookmarks.forEach((site) => {
filteredBookmarks.toList().sort(siteUtil.siteSort).forEach((site) => {
if (site.get('tags').includes(siteTags.BOOKMARK) && site.get('location')) {
title = site.get('customTitle') || site.get('title') || site.get('location')
payload.push(`${indentNext}<DT><A HREF="${site.get('location')}">${title}</A>`)
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.