This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRefactor download.js with Aphrodite #7258
Merged
Conversation
|
I left a comment asking for a minor change and otherwise LGTM |
app/renderer/components/list.js
Outdated
| this.props['data-isDownload'] && styles.isDownload | ||
| ) | ||
|
|
||
| return <list className={className} {...this.props} /> |
This comment has been minimized.
This comment has been minimized.
cezaraugusto
Feb 18, 2017
Contributor
I don't think <list> is a valid element. Lists are tagged as grouping content and AFAICT this tag is not included as one. Can we replace that with just a div? btw ok to keep component name as List.
Ref: https://www.w3.org/community/webed/wiki/HTML/Elements#Grouping_content
| overflow: 'hidden', | ||
| whiteSpace: 'nowrap', | ||
| padding: '8px 12px', | ||
| WebkitUserSelect: 'none', |
This comment has been minimized.
This comment has been minimized.
luixxiul
added
PR/work-in-progress 
| this.props['data-isDownload'] && styles.isDownload | ||
| ) | ||
|
|
||
| return <div className={className} {...this.props} /> |
This comment has been minimized.
This comment has been minimized.
This was referenced Feb 21, 2017
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
luixxiul commentedFeb 15, 2017
•
edited
including:
<List>and<DownloadList>in list.js&.selectedCloses #7255
Addresses #7318
Auditors: @bsclifton @cezaraugusto
Test Plan:
git rebase -ito squash commits (if needed).Test Plan: