Skip to content
This repository has been archived by the owner. It is now read-only.

Improve wallet recovery algorithm #7289

Merged
merged 2 commits into from Feb 16, 2017
Merged

Improve wallet recovery algorithm #7289

merged 2 commits into from Feb 16, 2017

Conversation

@mrose17
Copy link
Member

mrose17 commented Feb 16, 2017

Test Plan

  1. about:preferences#payments, 'Advanced Settings..., 'Backup your Wallet', ' Save recovery file...', save as brave_wallet_recovery.txt`
  2. get a vanilla browser install and turn on the ledger -- this creates a new wallet (with a new wallet address)
  3. about:preferences#payments, 'Advanced Settings..., 'Recovery your Wallet', ' Import recovery keys', select brave_wallet_recovery.txt`
  4. verify that value of properties.wallet.address does not change after step 3

Description

Fixes #7288

Fixes #7288
@mrose17 mrose17 added this to the 0.13.5 milestone Feb 16, 2017
@mrose17 mrose17 self-assigned this Feb 16, 2017
@mrose17 mrose17 requested a review from bsclifton Feb 16, 2017
Copy link
Member

bsclifton left a comment

Tried it out; worked as expected. LGTM 😄

@bsclifton bsclifton merged commit e0fc770 into master Feb 16, 2017
0 of 3 checks passed
0 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
@bsclifton bsclifton deleted the issue-7288 branch Feb 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.