Skip to content
This repository has been archived by the owner. It is now read-only.

/ browser-laptop Archived

View certificate on padlock #7319

Merged
merged 1 commit into from Mar 24, 2017
Merged

View certificate on padlock #7319

merged 1 commit into from Mar 24, 2017

Conversation

@darkdh
Copy link
Member

darkdh commented Feb 20, 2017 •
edited

Test Plan:

(on Mac and Windows)

  1. Open https site
  2. Click padlock
  3. Click view certificate
  4. certificate detail will show up in dialog

fix #6157

requires brave/muon#162

Auditors: @bridiver, @bbondy

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
@darkdh darkdh self-assigned this Feb 20, 2017
@darkdh darkdh requested review from bridiver and bbondy Feb 20, 2017
@darkdh darkdh added this to the 0.13.6 milestone Mar 11, 2017
@darkdh darkdh mentioned this pull request Mar 13, 2017
Closed
@darkdh
Front end work of view certificate
Verified
This commit was signed with a verified signature.
darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits
Loading status checks…
399be44 
Hide view certificate button until muon support linux

fix #6157

Auditors: @bridiver, @bbondy
@darkdh darkdh force-pushed the view_certificate branch from c1e2120 to 399be44 Mar 13, 2017
@luixxiul
Copy link
Contributor

luixxiul commented Mar 13, 2017

Should the position of the dialog be similar to #7107 (comment); under the URL bar maybe?
@bsclifton bsclifton modified the milestones: 0.14.1, 0.14.0 Mar 17, 2017
@bsclifton
Copy link
Member

bsclifton commented Mar 17, 2017

moving to 0.14.1; brave/muon#162 hasn't been accepted yet
@bsclifton bsclifton modified the milestones: 0.14.0, 0.14.1 Mar 24, 2017
@bsclifton
Copy link
Member

bsclifton commented Mar 24, 2017

Moved back to 0.14.0 after Muon changes were merged (builds are in progress I believe). Merging 😄
@bsclifton bsclifton merged commit 7a8e482 into master Mar 24, 2017
0 of 3 checks passed
0 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
@bsclifton bsclifton deleted the view_certificate branch Mar 24, 2017
@srirambv srirambv mentioned this pull request Mar 24, 2017
Closed
@jonathansampson jonathansampson mentioned this pull request May 14, 2017
Closed
@luixxiul luixxiul mentioned this pull request Feb 5, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bridiver bridiver

@bbondy bbondy

Assignees

@darkdh darkdh

Labels
feature/URLbar
Projects
None yet
Milestone
  0.14.0
Linked issues

Successfully merging this pull request may close these issues.

Show more details on secure connections
3 participants
@darkdh @luixxiul @bsclifton
You can’t perform that action at this time.