This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upOption to clear Sync server data and local browser state #7349
Conversation
| @@ -242,6 +274,14 @@ class SyncTab extends ImmutableComponent { | |||
| </div> | |||
| : null | |||
| } | |||
| { | |||
| this.isSetup | |||
| ? <div class='syncClearData'> | |||
This comment has been minimized.
This comment has been minimized.
diracdeltas
Feb 21, 2017
•
Member
i think react is throwing a warning because it expects className here
app/sync.js
Outdated
| if (dispatcherCallback) { | ||
| dispatcherCallback({actionType: syncConstants.SYNC_DELETE_USER}) | ||
| } | ||
| appActions.changeSetting(settings.SYNC_ENABLED, false) |
This comment has been minimized.
This comment has been minimized.
diracdeltas
Feb 21, 2017
Member
i would wait a short amount of time to call this to make sure that SYNC_DELETE_USER gets processed before the extension is disabled
This comment has been minimized.
This comment has been minimized.
ayumi
Feb 21, 2017
Author
Contributor
could also add an IPC message for DELETED_USER and wait for that
This comment has been minimized.
This comment has been minimized.
|
test plan worked for me. |
ayumi
added a commit
to brave/sync
that referenced
this pull request
Feb 22, 2017
To address brave/browser-laptop#7349 (review) Auditors: @diracdeltas
Fix #7275 Fix brave/sync#51
|
@diracdeltas have addressed comments. deleting data requires sync to be enabled because it needs a valid AWS credential to issue the delete request. i've added a little message to explain:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ayumi commentedFeb 21, 2017
•
edited
Fix #7275
Fix brave/sync#51
git rebase -ito squash commits (if needed).Test Plan:
npm run start2). Add it to 0's Sync profile and see the bookmarks sync over.Pix
