This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded npm task for getting unit test coverage #7391
Merged
Conversation
|
Now that we can get coverage, we can look at services like these (which are free for open source projects!):
|
|
One that is also very strong is Codecov |
…ge using istanbul. Auditors: @alexwykoff, @bbondy Fixes #6473
|
I re-ran failing tests; the ones which fail are also failing in master (they are not because of this). I did take a few minutes to make the alert tests more reliable. Since this is very low impact and haven't gotten a review, I'll go ahead and merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bsclifton commentedFeb 26, 2017
•
edited
Test plan
git clone git@github.com:brave/browser-laptop.gitcd browser-laptopnpm run unittest-covDescription
Added new
unittest-covnpm task which reports (via CLI) code coverage using istanbul.Auditors: @alexwykoff, @bbondy
Fixes #6473
git rebase -ito squash commits (if needed).Notes
test/mocha.optsExample output