Skip to content
This repository has been archived by the owner. It is now read-only.

do not delete objectIds when sync is reset #7420

Merged
merged 1 commit into from Mar 8, 2017
Merged

do not delete objectIds when sync is reset #7420

merged 1 commit into from Mar 8, 2017

Conversation

@diracdeltas
Copy link
Member

diracdeltas commented Feb 28, 2017

save the original seed for bookmarks, so they can be synced to a profile with
a different seed if needed. fix #7405.

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

  1. create a bookmark and a bookmark folder in pyramid 0 and enable sync.
  2. sync pyramid 1 to pyramid 0. wait for the bookmark and folder to appear.
  3. reset sync in pyramid 1
  4. re-sync pyramid 1 to pyramid 0
  5. in pyramid 1, move the bookmark into the folder. this change should sync correctly to pyramid 0.
  6. reset sync again in pyramid 1
  7. delete pyramid 0 completely
  8. choose 'i am new to sync' in pyramid 1
  9. start pyramid 0. it should have no bookmarks. sync it to pyramid 1's new profile
  10. the bookmarks from pyramid 1 should appear in pyramid 0
@diracdeltas diracdeltas added this to the 0.13.6 milestone Feb 28, 2017
@diracdeltas diracdeltas requested a review from ayumi Feb 28, 2017
@diracdeltas diracdeltas force-pushed the fix/7405 branch from 5dfc632 to 754c29d Feb 28, 2017
save the original seed for bookmarks, so they can be synced to a profile with
a different seed if needed. fix #7405.
@diracdeltas diracdeltas requested a review from srirambv Feb 28, 2017
@ayumi
ayumi approved these changes Mar 1, 2017
Copy link
Contributor

ayumi left a comment

success. that was a difficult test plan.

@diracdeltas diracdeltas merged commit 56dc556 into master Mar 8, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
@diracdeltas diracdeltas deleted the fix/7405 branch Mar 8, 2017
@srirambv
Copy link
Collaborator

srirambv commented Mar 15, 2017

@diracdeltas Steps 1-5 not working on clean profiles for 0.14.0 Preview 1
7420

@ayumi
Copy link
Contributor

ayumi commented Mar 15, 2017

@srirambv 1–5 worked for me, MacOS, master @ 131fce7

@diracdeltas
Copy link
Member Author

diracdeltas commented Mar 15, 2017

1-5 also worked for me on master, once i fixed the issue that was causing the sync server to not work for me at all.

@luixxiul
Copy link
Contributor

luixxiul commented Mar 29, 2017

the step 5 (in pyramid 1, move the bookmark into the folder. this change should sync correctly to pyramid 0) does not work between Windows 10 32 bit and macOS.

The sync itself is working between them, since another bookmark was synced successfully after moving the bookmark into the folder, which was not synced.

@srirambv
Copy link
Collaborator

srirambv commented Mar 30, 2017

All steps work fine on Windows(Pyramid 1) and Linux(Pyramid 0).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.