This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign updo not delete objectIds when sync is reset #7420
Merged
Conversation
|
success. that was a difficult test plan. |
|
@diracdeltas Steps 1-5 not working on clean profiles for 0.14.0 Preview 1 |
|
1-5 also worked for me on master, once i fixed the issue that was causing the sync server to not work for me at all. |
|
the step 5 (in pyramid 1, move the bookmark into the folder. this change should sync correctly to pyramid 0) does not work between Windows 10 32 bit and macOS. The sync itself is working between them, since another bookmark was synced successfully after moving the bookmark into the folder, which was not synced. |
|
All steps work fine on Windows(Pyramid 1) and Linux(Pyramid 0). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.

diracdeltas commentedFeb 28, 2017
•
edited
save the original seed for bookmarks, so they can be synced to a profile with
a different seed if needed. fix #7405.
git rebase -ito squash commits (if needed).Test Plan: