Skip to content
This repository has been archived by the owner. It is now read-only.

remove about:preferences from web_accessible_resources #7484

Merged
merged 1 commit into from Mar 7, 2017

Conversation

@diracdeltas
Copy link
Member

diracdeltas commented Mar 3, 2017

fix #4913

Auditors: @bridiver

Test Plan:

  1. open about:preferences and open devtools
  2. the top-level HTTP response should not show an 'Access-Control-Allow-Origin' header
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
@diracdeltas diracdeltas added the security label Mar 3, 2017
@diracdeltas diracdeltas added this to the 0.13.6 milestone Mar 3, 2017
@diracdeltas
Copy link
Member Author

diracdeltas commented Mar 3, 2017

@feross relatedly, i noticed webtorrent exposes 'webtorrent.html' in web_accessible_resources. if this is not necessary i recommend removing it.

@diracdeltas diracdeltas force-pushed the fix/web-accessible-prefs branch from 347458e to 437213c Mar 7, 2017
fix #4913

Auditors: @bridiver

Test Plan:
1. open about:preferences and open devtools
2. the top-level HTTP response should not show an 'Access-Control-Allow-Origin' header
@diracdeltas
Copy link
Member Author

diracdeltas commented Mar 7, 2017

merging based on #4913 (comment)

@diracdeltas diracdeltas merged commit 10a8198 into master Mar 7, 2017
0 of 3 checks passed
0 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
@diracdeltas diracdeltas deleted the fix/web-accessible-prefs branch Mar 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.