Skip to content
This repository has been archived by the owner. It is now read-only.

Make Payments FAQ link obvious #7488

Merged
merged 1 commit into from Mar 13, 2017
Merged

Make Payments FAQ link obvious #7488

merged 1 commit into from Mar 13, 2017

Conversation

@cndouglas
Copy link

cndouglas commented Mar 4, 2017

Test plan

  1. With a new session, launch Brave, open preferences, and go to Payments
  2. The FAQ link should be orange (per screenshot below) and very obviously be a link
  3. Click link, confirm it goes to FAQ

Description

Fixes #7487

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan: See issue #7487 for QA steps.

Screenshot:
image

@cndouglas cndouglas self-assigned this Mar 4, 2017
@bsclifton bsclifton added this to the 0.13.6 milestone Mar 13, 2017
Fixes #7487
@bsclifton bsclifton self-requested a review Mar 13, 2017
Copy link
Member

bsclifton left a comment

Looks great, thanks! 😄

@bsclifton bsclifton merged commit ba78b54 into brave:master Mar 13, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@cndouglas cndouglas deleted the cndouglas:payments-FAQ branch Mar 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.