Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdding decimal place for time saved stats #7489
Conversation
Fixes #6650 Time saved in hours will now have 1 decimal place. And time saved in days will have 2 decimal places Auditors: @bbondy @bsclifton
|
Great work, @maaz93! Huge |
|
@maaz93 if you're interested, another very similar issue (but more difficult) would be #5889 When testing the above and putting a HUGE number of ads in place (via my session), I noticed it overflow like so: The actual number is |
|
Thanks @bsclifton ! |

maazadeeb commentedMar 4, 2017
•
edited by bsclifton
Fixes #6650
Time saved in hours will now have 1 decimal place. And time saved
in days will have 2 decimal places
Auditors: @bbondy @bsclifton
git rebase -ito squash commits (if needed).Test Plan
~/Libraries/Application Support/brave/session-state-1on macOS,%appdata%\brave\session-state-1on Windows) in an editor such as Sublime, vim, notepad, etc. If you have a JSON formatting plugin, you may wish to use it (so that it's easier to edit)adblock>countto be555555(six fives)adblock>countvalue to be55555555(eight fives)