Skip to content
This repository has been archived by the owner. It is now read-only.

/ browser-laptop Archived

Avoid race condition on publisherToggle #7498

Merged
merged 1 commit into from Mar 9, 2017
Merged

Avoid race condition on publisherToggle #7498

merged 1 commit into from Mar 9, 2017

Conversation

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Mar 4, 2017 •
edited by bsclifton

Auditors: @bsclifton

Fix #7497

Test Plan:

  1. Have a clean session file
  2. Go to preferences->payments
  3. Enable payments
  4. Open browser console
  5. Go to an url from there
  6. No errors should be thrown
  7. Url should load instantly
@cezaraugusto cezaraugusto added this to the 0.13.6 milestone Mar 4, 2017
@cezaraugusto cezaraugusto self-assigned this Mar 4, 2017
@cezaraugusto cezaraugusto requested a review from bsclifton Mar 4, 2017
@cezaraugusto cezaraugusto mentioned this pull request Mar 4, 2017
Closed
@cezaraugusto
Avoid race condition on publisherToggle
Verified
This commit was signed with a verified signature.
cezaraugusto Cezar Augusto
GPG key ID: ECC5FF1C7EA1D39D Learn about signing commits
Loading status checks…
f587533 
Auditors: @bsclifton

Fix #7497
@bsclifton
bsclifton approved these changes Mar 9, 2017
View changes
Copy link
Member

bsclifton left a comment

++
@bsclifton bsclifton merged commit f6e9063 into brave:master Mar 9, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@bsclifton bsclifton mentioned this pull request Mar 10, 2017
Closed
@cezaraugusto cezaraugusto deleted the cezaraugusto:hotfix/7497 branch Jul 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton

Assignees

@cezaraugusto cezaraugusto

Labels
settings
Projects
None yet
Milestone
  0.14.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@cezaraugusto @bsclifton
You can’t perform that action at this time.