Skip to content
This repository has been archived by the owner. It is now read-only.

'hide sites with <1% usage' should be default on in about:preferences#payments #7522

Merged
merged 1 commit into from Mar 7, 2017

Conversation

@mrose17
Copy link
Member

mrose17 commented Mar 7, 2017

Fixes #7520

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

  • bring up a brand new browser with no state
  • go to about:preferences#payments
  • click on 'Advanced Settings'
  • verify that 'Hide sites with less than 1% usage' is enabled
Fixes #7520
@mrose17 mrose17 added this to the 0.13.6 milestone Mar 7, 2017
@mrose17 mrose17 self-assigned this Mar 7, 2017
@mrose17 mrose17 requested a review from diracdeltas Mar 7, 2017
@diracdeltas
Copy link
Member

diracdeltas commented Mar 7, 2017

lgtm with a proper commit message.

in the future, please assign an issue to yourself when you start working on it. i had assigned #7520 to myself and already made a patch for it too.

@mrose17
Copy link
Member Author

mrose17 commented Mar 7, 2017

oops! i thought i was getting it... sorry!

@mrose17 mrose17 changed the title Initial check-in 'hide sites with <1% usage' should be default on in about:preferences#payments Mar 7, 2017
@mrose17 mrose17 merged commit 83c55eb into master Mar 7, 2017
0 of 3 checks passed
0 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@mrose17 mrose17 deleted the issue-7520 branch Mar 7, 2017
@diracdeltas

This comment has been minimized.

Copy link
Member

diracdeltas commented on 49f1384 Mar 7, 2017

in the future, please use a descriptive commit message

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.