This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up'hide sites with <1% usage' should be default on in about:preferences#payments #7522
Conversation
|
lgtm with a proper commit message. in the future, please assign an issue to yourself when you start working on it. i had assigned #7520 to myself and already made a patch for it too. |
|
oops! i thought i was getting it... sorry! |
This comment has been minimized.
This comment has been minimized.
|
in the future, please use a descriptive commit message |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mrose17 commentedMar 7, 2017
•
edited by bsclifton
Fixes #7520
git rebase -ito squash commits (if needed).Test Plan: