Need new strings to handle overdue payments #7524

mrose17 · 2017-03-07T23:57:54Z

Submitted a ticket for my issue if one did not already exist.
Used Github auto-closing keywords in the commit message.
Added/updated tests for this change (for new code or code which already has tests).
Ran git rebase -i to squash commits (if needed).

Test Plan:

Create a new wallet
Stop browser
Set reconcileStamp ledger-state.json to the current timestamp or more than a day in the past.
Verify that the text indicates "is due" an "is coverdue" instead of suggesting a future event.


        Need new strings to handle overdue payments

Fixes #7078

bsclifton · 2017-03-10T08:34:27Z

app/extensions/brave/locales/en-US/preferences.properties

@@ -198,7 +200,7 @@ ledgerRecoveryFailedTitle=Recovery Failed
 ledgerRecoveryFailedMessage=Please re-enter keys or try different keys.
 ledgerRecoveryNetworkFailedTitle=Network Error
 ledgerRecoveryNetworkFailedMessage=Please check your internet connection and try again.
-ledgerRecoveryContent=The balance of the recovered wallet will be transferred to your new Brave wallet. The old wallet will still exist as an empty wallet.
+ledgerRecoveryContent=Your previous wallet will now be used. Your new wallet will be discarded.


Just to confirm:
@mrose17 when you do a restore, it'll use the previous wallet (what you just restored), right? So the old text here (about transferring the balance to your new wallet) was wrong?

correct. wallet recovery is now actually "recovery of old wallet" rather than "transfer the balance of the old wallet to the new wallet"

NejcZdovc · 2017-03-10T10:31:03Z

Regarding payment history button I think this is not relevant any more, because we removed payment history button and added only the icon, more in #7532

bsclifton

++

bsclifton · 2017-03-10T21:48:58Z

@NejcZdovc I believe the strings are also shown when you click the icon (and it shows the statements)

Although, if that new icon isn't clickable then the strings may not be needed

Need new strings to handle overdue payments

Loading status checks…

8e12037

Fixes #7078

mrose17 added the feature/rewards label Mar 7, 2017

mrose17 added this to the 0.13.6 milestone Mar 7, 2017

mrose17 self-assigned this Mar 7, 2017

mrose17 requested a review from bsclifton Mar 7, 2017

bsclifton reviewed Mar 10, 2017

View changes

bsclifton approved these changes Mar 10, 2017

View changes

bsclifton deleted the issue-7078 branch Mar 10, 2017

bsclifton added QA/test-plan-specified release-notes/include labels Mar 10, 2017

bsclifton mentioned this pull request Mar 13, 2017

Added new strings to handle overdue payments #7078

Closed

luixxiul removed QA/test-plan-specified release-notes/include labels Mar 15, 2017

brave / browser-laptop Archived

Need new strings to handle overdue payments #7524

Need new strings to handle overdue payments #7524

mrose17 commented Mar 7, 2017 •

edited by bsclifton

This comment has been minimized.

This comment has been minimized.

NejcZdovc commented Mar 10, 2017

bsclifton left a comment

bsclifton commented Mar 10, 2017 •

edited

brave / browser-laptop Archived

Join GitHub today

Need new strings to handle overdue payments #7524

Need new strings to handle overdue payments #7524

Conversation

mrose17 commented Mar 7, 2017 • edited by bsclifton

Test Plan:

This comment has been minimized.

bsclifton Mar 10, 2017

This comment has been minimized.

mrose17 Mar 10, 2017

NejcZdovc commented Mar 10, 2017

bsclifton left a comment

bsclifton commented Mar 10, 2017 • edited

mrose17 commented Mar 7, 2017 •

edited by bsclifton

bsclifton commented Mar 10, 2017 •

edited