Skip to content
This repository has been archived by the owner. It is now read-only.

Replace ellipsis with fade-out for tab title #7564

Merged
merged 1 commit into from Mar 8, 2017
Merged

Conversation

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Mar 8, 2017

Auditors: @ayumi

Fix #7535

cc @bradleyrichter

screen shot 2017-03-08 at 11 26 02 am

Test plan:

  1. Have a page open that has themeColor: i.e. https://brianbondy.com, and another with no themeColor: i.e. about page
  2. Should be aesthetically OK on tab's active/inactive states.
  3. Should be aesthetically OK when resized
  4. Should be aesthetically OK on private/new session tabs
@cezaraugusto cezaraugusto self-assigned this Mar 8, 2017
@cezaraugusto cezaraugusto requested review from ayumi, bbondy and bsclifton Mar 8, 2017
@cezaraugusto cezaraugusto added this to the 0.13.6 milestone Mar 8, 2017
@ayumi
Copy link
Contributor

ayumi commented Mar 8, 2017

this is minor but I'd like a more subtle fade like

screen shot 2017-03-08 at 19 43 43

@cezaraugusto
Copy link
Contributor Author

cezaraugusto commented Mar 8, 2017

ok updated

screen shot 2017-03-08 at 1 12 27 pm

Auditors: @ayumi

Close #7535
@ayumi
Copy link
Contributor

ayumi commented Mar 8, 2017

minor: for me private tabs when first opened have white text on white background
screen shot 2017-03-08 at 21 18 00

@ayumi
ayumi approved these changes Mar 8, 2017
Copy link
Contributor

ayumi left a comment

besides minor comment lgtm

Copy link
Member

bsclifton left a comment

Awesome work! This may be a small change, but I feel like it polishes up Brave quite a bit. I checked against Chrome and the behavior seems to match EXCEPT (not related to this PR) the close button is always shown for tabs in Chrome.

@bradleyrichter do we want to consider always showing the X for the close button?

@bsclifton bsclifton merged commit d6515fa into brave:master Mar 8, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@cezaraugusto cezaraugusto deleted the cezaraugusto:tabsbar/7535 branch Jul 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.