This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReplace ellipsis with fade-out for tab title #7564
Merged
Conversation
|
besides minor comment lgtm |
|
Awesome work! This may be a small change, but I feel like it polishes up Brave quite a bit. I checked against Chrome and the behavior seems to match EXCEPT (not related to this PR) the close button is always shown for tabs in Chrome. @bradleyrichter do we want to consider always showing the X for the close button? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.



cezaraugusto commentedMar 8, 2017
Auditors: @ayumi
Fix #7535
cc @bradleyrichter
Test plan: