Skip to content
This repository has been archived by the owner. It is now read-only.

show grey insecure icon for passive mixed content #7571

Merged
merged 1 commit into from Mar 10, 2017
Merged

show grey insecure icon for passive mixed content #7571

merged 1 commit into from Mar 10, 2017

Conversation

@diracdeltas
Copy link
Member

diracdeltas commented Mar 8, 2017

fix #2168

Auditors: @darkdh

Test Plan:

  1. automated tests related to lockIcon should pass
  2. go to mixed.badssl.com; the icon should be a grey unlocked icon
  3. clicking on the icon should tell you that the page is partially insecure
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
fix #2168

Auditors: @darkdh

Test Plan:
1. automated tests related to lockIcon should pass
2. go to mixed.badssl.com; the icon should be a grey unlocked icon
3. clicking on the icon should tell you that the page is partially insecure
@diracdeltas diracdeltas added this to the 0.13.6 milestone Mar 8, 2017
@diracdeltas diracdeltas requested a review from darkdh Mar 8, 2017
@darkdh
darkdh approved these changes Mar 10, 2017
Copy link
Member

darkdh left a comment

++

@darkdh darkdh merged commit e2905d5 into master Mar 10, 2017
0 of 3 checks passed
0 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
@diracdeltas diracdeltas deleted the feature/2168 branch Mar 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.