Skip to content
This repository has been archived by the owner. It is now read-only.

Re-enable ping to stats server for linux #7651

Merged
merged 1 commit into from Mar 12, 2017
Merged

Re-enable ping to stats server for linux #7651

merged 1 commit into from Mar 12, 2017

Conversation

@aekeus
Copy link
Member

aekeus commented Mar 10, 2017

This change re-enables the update check, used to send anonymous stats, for Linux.

The update check does not show the update bar, even if there is a newer version
of the software available. This will be addressed in a later commit.

Testing:

Testing this change from a QA perspective is problematic. These are the steps
I used to test the functionality of the change.

A)

  • Change the version in package.json to a previous release version
  • Build the binary on Linux
  • Launch the browser ensuring:
    • The browser does not crash on update init
    • The updater scheduler is initiated
    • Metadata is retrieved from the updater
    • The updater bar is NOT shown
    • The browser does not crash
    • No attempt is made to update the browser binary

B)

  • Change the browser version in package.json to a non-existent version
  • Build on Linux and launch
  • Ensure no metadata is retrieved
  • Ensure that the ping is recorded in the dw.fc_usage table of stats

Auditors: @bbondy

Implements: #7562

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

This change re-enables the update check, used to send anonymous stats, for Linux.

The update check does not show the update bar, even if there is a newer version
of the software available. This will be addressed in a later commit.

Testing:

Testing this change from a QA perspective is problematic. These are the steps
I used to test the functionality of the change.

A)

  * Change the version in package.json to a previous release version
  * Build the binary on Linux
  * Launch the browser ensuring:
    * The browser does not crash on update init
    * The updater scheduler is initiated
    * Metadata is retrieved from the updater
    * The updater bar is NOT shown
    * The browser does not crash
    * No attempt is made to update the browser binary

B)

  * Change the browser version in package.json to a non-existent version
  * Build on Linux and launch
  * Ensure no metadata is retrieved
  * Ensure that the ping is recorded in the dw.fc_usage table of stats

Auditors: @bbondy

Implements: #7562
@aekeus aekeus added this to the 0.13.6 milestone Mar 10, 2017
@bbondy
Copy link
Member

bbondy commented Mar 12, 2017

thanks for taking this and for splitting it up.

@bbondy bbondy merged commit 870fd32 into master Mar 12, 2017
0 of 3 checks passed
0 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
@cezaraugusto cezaraugusto deleted the linux-stats branch Jun 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.