This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRe-enable ping to stats server for linux #7651
Merged
Conversation
This change re-enables the update check, used to send anonymous stats, for Linux.
The update check does not show the update bar, even if there is a newer version
of the software available. This will be addressed in a later commit.
Testing:
Testing this change from a QA perspective is problematic. These are the steps
I used to test the functionality of the change.
A)
* Change the version in package.json to a previous release version
* Build the binary on Linux
* Launch the browser ensuring:
* The browser does not crash on update init
* The updater scheduler is initiated
* Metadata is retrieved from the updater
* The updater bar is NOT shown
* The browser does not crash
* No attempt is made to update the browser binary
B)
* Change the browser version in package.json to a non-existent version
* Build on Linux and launch
* Ensure no metadata is retrieved
* Ensure that the ping is recorded in the dw.fc_usage table of stats
Auditors: @bbondy
Implements: #7562
|
thanks for taking this and for splitting it up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aekeus commentedMar 10, 2017
This change re-enables the update check, used to send anonymous stats, for Linux.
The update check does not show the update bar, even if there is a newer version
of the software available. This will be addressed in a later commit.
Testing:
Testing this change from a QA perspective is problematic. These are the steps
I used to test the functionality of the change.
A)
B)
Auditors: @bbondy
Implements: #7562
git rebase -ito squash commits (if needed).Test Plan: