Skip to content
This repository has been archived by the owner. It is now read-only.

do not accidentally show password as username #7653

Merged
merged 2 commits into from Mar 12, 2017
Merged

do not accidentally show password as username #7653

merged 2 commits into from Mar 12, 2017

Conversation

@diracdeltas
Copy link
Member

diracdeltas commented Mar 11, 2017

fix #7649

Test Plan:

  1. automated tests for notificationBar should pass
  2. changing the password on https://reg.ebay.com/reg/ChangePwd and clicking 'submit' should not show the current password in the notification bar
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
fix #7649

Test Plan:
1. automated tests for notificationBar should pass
2. changing the password on https://reg.ebay.com/reg/ChangePwd and clicking 'submit' should not show the current password in the notification bar
@diracdeltas diracdeltas requested a review from bbondy Mar 11, 2017
@diracdeltas diracdeltas added this to the 0.13.6 milestone Mar 11, 2017
@bbondy
Copy link
Member

bbondy commented Mar 12, 2017

++

@bbondy bbondy merged commit 99efb5a into master Mar 12, 2017
0 of 3 checks passed
0 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
@diracdeltas diracdeltas deleted the fix/7649 branch Mar 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.