Skip to content
This repository has been archived by the owner. It is now read-only.

Advance settings not being clickable #7660

Merged
merged 1 commit into from Mar 12, 2017

Conversation

@NejcZdovc
Copy link
Member

NejcZdovc commented Mar 12, 2017

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Resolves #7452

Auditors

@bsclifton @cezaraugusto

Test Plan

  • go to about:preferences
  • switch to Russian
  • advance settings should always be clickable (wait for a long text)
Resolves #7452

Auditors:
@bsclifton @cezaraugusto

Test Plan:
- go to about:preferences
- switch to Russian
- advance settings should always be clickable
@NejcZdovc NejcZdovc added the settings label Mar 12, 2017
@NejcZdovc NejcZdovc added this to the 0.13.6 milestone Mar 12, 2017
@NejcZdovc NejcZdovc self-assigned this Mar 12, 2017
@NejcZdovc NejcZdovc requested review from cezaraugusto and bsclifton Mar 12, 2017
Copy link
Member

bsclifton left a comment

I was only able to reproduce on Windows (which I have at 125% DPI). Change looks great! 😄

Copy link
Contributor

cezaraugusto left a comment

++

@cezaraugusto cezaraugusto merged commit 3ad0f41 into brave:master Mar 12, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.