This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReplace float:right with flex model on alert dialogs #7674
Merged
Conversation
Follow-up of #7107 (#7107 (comment)) Closes #7673 Auditors: Test Plan: 1. Visit http://jsbin.com/fiyojusahu/edit?html,output 2. In the `output` area, click the `Click me to test an alert` button 3. Make sure the buttons are aligned to the right 4. Visit http://jsbin.com/sadunogefu/edit?html,output 5. In the `output` area, click the `Click me to test a confirm` button 6. Make sure the buttons are aligned to the right
|
Manually tested on Windows 10, looks great! |
|
++ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
luixxiul commentedMar 13, 2017
•
edited by bsclifton
Test Plan:
outputarea, click theClick me to test an alertbuttonoutputarea, click theClick me to test a confirmbuttonDescription
Follow-up of #7107 (#7107 (comment))
Closes #7673
Auditors: @bsclifton, @cezaraugusto
git rebase -ito squash commits (if needed).