This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImprovement of buttons on TorrentViewer #7679
Merged
Conversation
less/webtorrent.less
Outdated
| border-bottom: 2px solid @braveOrange; | ||
| box-shadow: @buttonShadow; | ||
| color: white; | ||
| .mainButton {; |
This comment has been minimized.
This comment has been minimized.
- Removed redundant rules, adding "primaryButton" class - Removed float:right by aligning the buttons on the js file Fixes #6735 Auditors: Test Plan: 1. Visit https://codepen.io/ferossity/full/qaezaB/ 2. Open any link on the page in a new tab 3. Make sure there is a gap between the buttons on the header
|
Updated, ready for reviewing |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
luixxiul commentedMar 13, 2017
•
edited by bsclifton
Test Plan:
Description
Fixes #6735
Auditors: @cezaraugusto
git rebase -ito squash commits (if needed).Test Plan: