Skip to content
This repository has been archived by the owner. It is now read-only.

Make private tab color predominant #7722

Merged
merged 1 commit into from Mar 15, 2017
Merged

Make private tab color predominant #7722

merged 1 commit into from Mar 15, 2017

Conversation

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Mar 15, 2017

Auditors: @bsclifton

Fix #7720
Fix #7715

purple_is_the_new_private

/cc @bradleyrichter

Test Plan:

  • If a tab is private, it should be purple even if themeColor is defined
Copy link
Member

bsclifton left a comment

Changes look great 😄 ++

Copy link
Member

bsclifton left a comment

I was playing around with session tabs for comparison and noticed a bug (similar in nature to this)

If you open a new session tab and switch to it, the close button is white when you do a mouse over:
screen shot 2017-03-14 at 10 46 44 pm

@jonathansampson
Copy link
Collaborator

jonathansampson commented Mar 15, 2017

@bsclifton I'm not able to repro the New Session Tab issue you're seeing:

image

Copy link
Collaborator

jonathansampson left a comment

I see no issues in my quick test, but @bsclifton did.

@cezaraugusto
Copy link
Contributor Author

cezaraugusto commented Mar 15, 2017

@bsclifton can't repro. Can you give a more detailed STR?

Copy link
Member

bsclifton left a comment

weird- definitely can't repro now...

Before I tested (both today and yesterday), I did rebase against master. Yesterday may have had a conflict causing the white text; it works great now 😄

@bsclifton
Copy link
Member

bsclifton commented Mar 15, 2017

@cezaraugusto if you can go ahead and rebase, I'll merge (assuming @jonathansampson didn't have any objections 😄 )

@cezaraugusto
Copy link
Contributor Author

cezaraugusto commented Mar 15, 2017

thanks rebased

Auditors: @bsclifton

Fix #7720
Fix #7715
@bsclifton bsclifton merged commit 3b3ad3c into brave:master Mar 15, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@luixxiul luixxiul removed the request for review from NejcZdovc Mar 16, 2017
@cezaraugusto cezaraugusto deleted the cezaraugusto:tabsbar/7720 branch Jul 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.