This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove string from tab on persistent partition #7741
Merged
Conversation
Auditors: @bsclifton Fix #7716
Auditors: @cezaraugusto Test Plan: run `npm run unittest -- --grep="tabContent components"`
|
|
|
|
|
++++! |
|
++ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
cezaraugusto commentedMar 15, 2017
•
edited by bsclifton
Auditors: @bsclifton
Fix #7716
Issue was caused by persistent partitions being set as string instead of number
Test Plan:
target="_blank"linkpartition-string on its tab