Skip to content
This repository has been archived by the owner. It is now read-only.

Instantly show newTab title instead of location #7754

Merged
merged 1 commit into from Mar 17, 2017

Conversation

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Mar 16, 2017

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Auditors: @bbondy

Fix #7724

Test Plan: covered by automated test

npm run test -- --grep="shows new tab title instead of about:newtab"

QA steps:

  1. Open a new tab by any means (shortcut, plus button, menu)
  2. Newtab title should be "New Tab" instead of "about:newtab"
@cezaraugusto cezaraugusto added this to the 0.14.0 milestone Mar 16, 2017
@cezaraugusto cezaraugusto self-assigned this Mar 16, 2017
@cezaraugusto cezaraugusto requested a review from bbondy Mar 16, 2017
Auditors: @bbondy

Fix #7724

Test Plan: covered by automated test
@bsclifton bsclifton self-requested a review Mar 17, 2017
Copy link
Member

bsclifton left a comment

Tested it out (before and after these changes)- works great 😄 Thanks for doing the test too!

@bsclifton bsclifton merged commit 903cfea into brave:master Mar 17, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@cezaraugusto cezaraugusto deleted the cezaraugusto:hotfix/7724 branch Jul 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.