Skip to content
This repository has been archived by the owner. It is now read-only.

/ browser-laptop Archived

Update Standard@9.0.0 #7817

Merged
merged 2 commits into from Apr 3, 2017
Merged

Update Standard@9.0.0 #7817

merged 2 commits into from Apr 3, 2017

Conversation

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Mar 21, 2017

Auditors: @bsclifton

Fix #7492
Follow-up of #7495 and #7785

Will also help with standard version inconsistency between repo/travis (#7794)

This PR addressed the following new rules:

no-mixed-operators (follow-up with 1 occurency)
no-unused-expressions
prefer-promise-reject-errors
valid-typeof
no-useless-escape

Test plan:

  1. Run npm run lint
  2. Should have no linting errors
@cezaraugusto cezaraugusto self-assigned this Mar 21, 2017
@cezaraugusto cezaraugusto requested a review from bsclifton Mar 21, 2017
@diracdeltas
Copy link
Member

diracdeltas commented Mar 21, 2017

Note that this doesn't fully address #7794 because Travis is using latest Standard (9.0.2?) instead of 9.0.0. I believe we still need #7795 to fix that.
@cezaraugusto cezaraugusto mentioned this pull request Mar 21, 2017
Merged
4 of 4 tasks complete
@cezaraugusto
Copy link
Contributor Author

cezaraugusto commented Mar 21, 2017

how Travis handle deps updates? I think we can update this to match current Travis version
@diracdeltas
Copy link
Member

diracdeltas commented Mar 21, 2017

@cezaraugusto i think there is a bug in how travis invalidates caches; others report similar issues at travis-ci/travis-ci#3758. i'm not sure if shrinkwrapping helps but it might.
@diracdeltas
Copy link
Member

diracdeltas commented Mar 21, 2017

anyway i reverted caching on master for now
bsclifton referenced this pull request in darkdh/browser-laptop Mar 28, 2017
@darkdh
Only check third party url when not in main frame
Verified
This commit was signed with a verified signature.
darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits
fc24493 
fix brave#7916

Auditors: @bbondy, @bsclifton

Test Plan:
- Make sure automated tests are passing
  - `npm run test -- --grep=adBlockUtil`
- Make sure you don't see ads on YouTube.
- Make sure `http://downloadme.org/` will be reported as malicious site
@luixxiul luixxiul mentioned this pull request Mar 28, 2017
Closed
2 of 4 tasks complete
cezaraugusto and others added 2 commits Mar 21, 2017
@cezaraugusto @bsclifton
Update Standard@9.0.0
Unverified
This user has not uploaded their public key yet.
GPG key ID: 37FF5F19022427F2 Learn about signing commits
fd306bb 
Auditors: @bsclifton

Fix #7813
Follow-up of: #7495 and #7785

Test Plan: `npm run lint` should throw no errors
@bsclifton
Fix lint error
Unverified
This user has not uploaded their public key yet.
GPG key ID: 37FF5F19022427F2 Learn about signing commits
Loading status checks…
5fe21c6 
Fix broken unit test

Auditors: @cezaraugusto
@bsclifton
bsclifton approved these changes Apr 3, 2017
View changes
Copy link
Member

bsclifton left a comment

Rebased + added a fix for one more issue found. Also, I fixed a broken unit test. Looks good 😄
@bsclifton bsclifton merged commit 67a0eaa into brave:master Apr 3, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@cezaraugusto cezaraugusto deleted the cezaraugusto:update/standard9 branch Jul 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton

Assignees

@cezaraugusto cezaraugusto

Labels
QA/no-qa-needed dev-setup release-notes/exclude
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@cezaraugusto @diracdeltas @bsclifton
You can’t perform that action at this time.