Skip to content
This repository has been archived by the owner. It is now read-only.

Fixes Add Bookmarks in Bookmarks Manager #7829

Merged
merged 1 commit into from Mar 22, 2017

Conversation

@NejcZdovc
Copy link
Member

NejcZdovc commented Mar 22, 2017

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Resolves #7801

Note
Bug was introduced with this commit 583d178

Auditors

@bsclifton @darkdh

Test Plan

  • go to Bookmarks Manager
  • right click in a bookmarks area (right side)
  • select Add bookmark
  • bookmark dialog is opened
Resolves #7801

Auditors: @bsclifton @darkdh

Test Plan:
- go to Bookmarks Manager
- right click in a bookmarks area (right side)
- select Add bookmark
- bookmark dialog is opened
@NejcZdovc NejcZdovc added this to the 0.14.1 milestone Mar 22, 2017
@NejcZdovc NejcZdovc self-assigned this Mar 22, 2017
@NejcZdovc NejcZdovc requested review from bsclifton and darkdh Mar 22, 2017
@NejcZdovc NejcZdovc modified the milestones: 0.14.0, 0.14.1 Mar 22, 2017
Copy link
Member

bsclifton left a comment

++! 😄

@bsclifton bsclifton merged commit cd2ab02 into brave:master Mar 22, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@darkdh
Copy link
Member

darkdh commented Mar 22, 2017

Nice ++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.